[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20260126110936.4e47e1b0820198e342339038@linux-foundation.org>
Date: Mon, 26 Jan 2026 11:09:36 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Andreas Larsson <andreas@...sler.com>
Cc: chengkaitao <pilgrimtao@...il.com>, davem@...emloft.net,
david@...nel.org, lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com,
vbabka@...e.cz, rppt@...nel.org, surenb@...gle.com, mhocko@...e.com,
kevin.brodsky@....com, dave.hansen@...ux.intel.com, ziy@...dia.com,
chengkaitao@...inos.cn, willy@...radead.org, zhengqi.arch@...edance.com,
sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-mm@...ck.org
Subject: Re: [PATCH v5 1/2] sparc: Use vmemmap_populate_hugepages for
vmemmap_populate
On Mon, 26 Jan 2026 15:50:34 +0100 Andreas Larsson <andreas@...sler.com> wrote:
> On 2026-01-11 08:44, chengkaitao wrote:
> > From: Chengkaitao <chengkaitao@...inos.cn>
> >
> > 1. In the SPARC architecture, reimplemented vmemmap_populate using
> > vmemmap_populate_hugepages.
> > 2. Allow the SPARC arch to fallback to vmemmap_populate_basepages(),
> > when vmemmap_alloc_block returns NULL.
>
> This patch seems to potentially make more functional changes than what
> the descriptions gives impression of.
>
> Given the amount of changes this seems to introduce, more on that below,
> I'd like to see more description on the changes and why they can be done
> than this.
>
> Nit: use active language, "reimplement", not "reimplemented".
Thanks, I'll drop the v5 version of this patchset.
Powered by blists - more mailing lists