linux-kernel - Re: [PATCH v2] clk: vf610: Add support for the Ethernet switch clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260126203307.6076ba9c@wsk>
Date: Mon, 26 Jan 2026 20:33:07 +0100
From: Łukasz Majewski <lukma@...ladev.com>
To: Andrew Lunn <andrew@...n.ch>, Conor Dooley <conor+dt@...nel.org>
Cc: Abel Vesa <abelvesa@...nel.org>, Peng Fan <peng.fan@....com>, Michael
 Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Shawn
 Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam
 <festevam@...il.com>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] clk: vf610: Add support for the Ethernet switch
 clocks

Hi Andrew,

> On Mon, Jan 26, 2026 at 12:53:49PM +0100, Lukasz Majewski wrote:
> > From: Lukasz Majewski <lukma@...x.de>
> > 
> > The vf610 device has built in the MoreThanIP L2 switch. For proper
> > operation it is required to enable ESW and MAC table lookup clocks.
> > 
> > The MAC table spans from 0x400E_C000 for 0x4000 and it is necessary
> > to provide clocks for each AIPS1-"slot", which size is 0x1000
> > (hence four separate entries).
> > 
> > Those can be enabled via clock gating CCM_CCGR10 register
> > (0x4006_B068).
> > 
> > This patch also adds VF610_CLK_ESW and VF610_CLK_ESW_MAC_TAB{0123}
> > macros definitions for L2 switch.
> > 
> > The VF610_CLK_END has been removed as its number had to be increased
> > when MTIP L2 switch clocks were added.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@...ladev.com>
> > ---
> > Changes for v2:
> > - Squash clock DT bindings to this single patch
> > - Replace VF610_CLK_END with VF610_CLK_ESW_MAC_TAB3 + 1  
> 
> I'm not sure this is the correct thing to do. Normally these _END
> values are there so you don't need to change any code when new things
> are added to the list. 
> 
> Why not just keep VF610_CLK_END at the end, with the value of 196?
> 
>     Andrew

Conor (on CC) explicitly asked to remove VF610_CLK_END:
"[PATCH] dt-bindings: clock: vf610: Add definitions for MTIP L2 switch"

------>8------------
> -#define VF610_CLK_END			191  

If end is modifiable, it is removable. If you need the define for the
driver, please move it there.
------8<------------

I just follow what he asked.

-- 
Best regards,

Lukasz Majewski

--
Nabla Software Engineering GmbH
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office@...ladev.com
Managing Director : Stefano Babic