linux-kernel - Re: [PATCH 1/2] dt-bindings: power: supply: document Samsung S2MU005 battery fuel gauge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DFYSP9E4NKZY.2Q5YX7RUOXUD5@disroot.org>
Date: Tue, 27 Jan 2026 01:45:35 +0530
From: "Kaustabh Chakraborty" <kauschluss@...root.org>
To: "Conor Dooley" <conor@...nel.org>, "Kaustabh Chakraborty"
 <kauschluss@...root.org>
Cc: "Yassine Oudjana" <y.oudjana@...tonmail.com>, "Sebastian Reichel"
 <sre@...nel.org>, "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski"
 <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>,
 <linux-pm@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: document Samsung
 S2MU005 battery fuel gauge

On 2026-01-26 20:06 +00:00, Conor Dooley wrote:
> On Mon, Jan 26, 2026 at 09:09:48PM +0530, Kaustabh Chakraborty wrote:
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> +    i2c {
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +
>> +      fuelgauge@3b {
>
> Should be "fuel-gauge" iirc (at least, that's what all the bindings do).

There are a few which use "fuelgauge", but majority use "fuel-gauge".
Will change in the next revision.

> Seems fine to me though otherwise,
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> pw-bot: not-applicable
>
>> +        compatible = "samsung,s2mu005-fuel-gauge";
>> +        reg = <0x3b>;
>> +
>> +        interrupt-parent = <&gpa0>;
>> +        interrupts = <3 IRQ_TYPE_EDGE_BOTH>;
>> +
>> +        monitored-battery = <&battery>;
>> +      };
>> +    };
>> 
>> -- 
>> 2.52.0
>>