linux-kernel - Re: [PATCH V3 4/6] nvmet: ignore discard return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260126045716.GA31683@lst.de>
Date: Mon, 26 Jan 2026 05:57:16 +0100
From: "hch@....de" <hch@....de>
To: Chaitanya Kulkarni <chaitanyak@...dia.com>
Cc: Chaitanya Kulkarni <ckulkarnilinux@...il.com>,
	"axboe@...nel.dk" <axboe@...nel.dk>,
	"agk@...hat.com" <agk@...hat.com>,
	"snitzer@...nel.org" <snitzer@...nel.org>,
	"mpatocka@...hat.com" <mpatocka@...hat.com>,
	"song@...nel.org" <song@...nel.org>,
	"yukuai@...as.com" <yukuai@...as.com>, "hch@....de" <hch@....de>,
	"sagi@...mberg.me" <sagi@...mberg.me>,
	"jaegeuk@...nel.org" <jaegeuk@...nel.org>,
	"chao@...nel.org" <chao@...nel.org>,
	"cem@...nel.org" <cem@...nel.org>,
	"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dm-devel@...ts.linux.dev" <dm-devel@...ts.linux.dev>,
	"linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"linux-f2fs-devel@...ts.sourceforge.net" <linux-f2fs-devel@...ts.sourceforge.net>,
	"linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>,
	"Martin K . Petersen" <martin.petersen@...cle.com>,
	Johannes Thumshirn <johannes.thumshirn@....com>
Subject: Re: [PATCH V3 4/6] nvmet: ignore discard return value

On Sat, Jan 24, 2026 at 09:35:16PM +0000, Chaitanya Kulkarni wrote:
> On 11/24/25 15:48, Chaitanya Kulkarni wrote:
> > __blkdev_issue_discard() always returns 0, making the error checking
> > in nvmet_bdev_discard_range() dead code.
> >
> > Kill the function nvmet_bdev_discard_range() and call
> > __blkdev_issue_discard() directly from nvmet_bdev_execute_discard(),
> > since no error handling is needed anymore for __blkdev_issue_discard()
> > call.
> >
> > Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>
> > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>
> > Reviewed-by: Christoph Hellwig <hch@....de>
> > Signed-off-by: Chaitanya Kulkarni <ckulkarnilinux@...il.com>
> > ---
> 
> Gentle ping on this, can we apply this patch ?

Are we down to three patches now?  Maybe resend the whole series and
get ACKs to merge everything through the block layer?