[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20260126215134.25814c5a@wsk>
Date: Mon, 26 Jan 2026 21:51:34 +0100
From: Łukasz Majewski <lukma@...ladev.com>
To: Fabio Estevam <festevam@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Conor Dooley <conor+dt@...nel.org>, Abel
Vesa <abelvesa@...nel.org>, Peng Fan <peng.fan@....com>, Michael Turquette
<mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob Herring
<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Shawn Guo
<shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix
Kernel Team <kernel@...gutronix.de>, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] clk: vf610: Add support for the Ethernet switch
clocks
Hi Fabio,
> Hi Łukasz,
>
> On Mon, Jan 26, 2026 at 4:33 PM Łukasz Majewski <lukma@...ladev.com>
> wrote:
>
> > Conor (on CC) explicitly asked to remove VF610_CLK_END:
> > "[PATCH] dt-bindings: clock: vf610: Add definitions for MTIP L2
> > switch"
> > ------>8------------
> > > -#define VF610_CLK_END 191
> >
> > If end is modifiable, it is removable. If you need the define for
> > the driver, please move it there.
> > ------8<------------
> >
> > I just follow what he asked.
>
> You should still use VF610_CLK_END. Just define it inside the clk
> driver instead of in the dt-bindings.
>
> Please check these two i.MX93 patches that explain the rationale:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.19-rc7&id=c0813ce2e5b0d1174782aff30d366509377abc7b
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.19-rc7&id=0af18ba60752e8a4ba34404c1d9a4a799da690f5
Ok, if this is the agreed approach, I'm going to use it.
Thanks for pointing this out.
--
Best regards,
Lukasz Majewski
--
Nabla Software Engineering GmbH
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office@...ladev.com
Managing Director : Stefano Babic
Powered by blists - more mailing lists