[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <E1EA1F0E-0A78-4F6A-B67F-03E5CB8F0135@collabora.com>
Date: Mon, 26 Jan 2026 21:51:46 +0100
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Lyude Paul <lyude@...hat.com>
Cc: linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org,
rust-for-linux@...r.kernel.org,
Danilo Krummrich <dakr@...nel.org>,
nouveau@...ts.freedesktop.org,
Miguel Ojeda <ojeda@...nel.org>,
Simona Vetter <simona@...ll.ch>,
Alice Ryhl <aliceryhl@...gle.com>,
Shankari Anand <shankari.ak0208@...il.com>,
David Airlie <airlied@...il.com>,
Benno Lossin <lossin@...nel.org>,
Asahi Lina <lina+kernel@...hilina.net>
Subject: Re: [PATCH v4 0/3] Introduce DeviceContext
Hi Lyude,
> On 24 Jan 2026, at 00:10, Lyude Paul <lyude@...hat.com> wrote:
>
> Previous version of this patch series:
> https://patchwork.freedesktop.org/series/160217/#rev2
>
> One of the unsolved issues we still have with the rust DRM bindings is
> the ability to limit certain Device operations to contexts where we can
> guarantee that a Device has been fully initialized and registered with
> userspace, or vice-versa (e.g. must be unregistered).
>
> While the previous solution for this that I had was simply not exposing
> drm::Device at all until the device has been registered with userspace,
> unfortunately this isn't enough since:
>
> * As we found out with Tyr, drivers occasionally need to be able to
> create GEM objects before device registration
> * We would still need to be able to handle KMS callbacks which could be
> invoked after KMS init but before userspace registration (not handled
> in this series specifically, but DeviceContext will be required for
> handling this).
>
> This patch series provides a pretty nice solution to this, by
> implementing a very similar solution to kernel::device::DeviceContext:
> introducing our own DeviceContext type state.
>
> This patch series depends on the two pre-requisite patch series:
>
> * https://patchwork.freedesktop.org/series/160523/
>
> Series-wide changes
>
> V2:
> * s/DeviceCtx/DeviceContext/ for consistency
> * Move private driver-data availability to the Registration
> DeviceContext
> * s/AnyCtx/Init/
>
Did you forget the changelog for v3 and v4?
> More changes described in each patch description.
Seems to be the case for the individual patches as well.
Anyways, I will do a second round of reviews here; please
wait a bit before potentially merging a new iteration.
— Daniel
Powered by blists - more mailing lists