linux-kernel - Re: [PATCH v2 4/5] rust: io: add `register!` macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFYBQ4OIBF9K.3KTZQ2B88TT9L@nvidia.com>
Date: Mon, 26 Jan 2026 15:57:24 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Gary Guo" <gary@...yguo.net>
Cc: "Danilo Krummrich" <dakr@...nel.org>, "Alice Ryhl"
 <aliceryhl@...gle.com>, "Daniel Almeida" <daniel.almeida@...labora.com>,
 "Miguel Ojeda" <ojeda@...nel.org>, "Boqun Feng" <boqun.feng@...il.com>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Trevor
 Gross" <tmgross@...ch.edu>, "Yury Norov" <yury.norov@...il.com>, "John
 Hubbard" <jhubbard@...dia.com>, "Alistair Popple" <apopple@...dia.com>,
 "Joel Fernandes" <joelagnelf@...dia.com>, "Timur Tabi" <ttabi@...dia.com>,
 "Edwin Peer" <epeer@...dia.com>, "Eliot Courtney" <ecourtney@...dia.com>,
 "Dirk Behme" <dirk.behme@...bosch.com>, "Steven Price"
 <steven.price@....com>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/5] rust: io: add `register!` macro

On Mon Jan 26, 2026 at 12:24 PM JST, Alexandre Courbot wrote:
>> Another top-level question I have is whether we should define multiple registers
>> (perhaps all) in one macro invocation. That's the strategy of `tock-registers`
>> crate which is widely used in embedded Rust.
>
> I agree that would be nice, especially as it opens the way for better
> syntax for e.g. register blocks with a base.
>
> I am having trouble adding that to the current design though. Some rules
> use the tt muncher pattern and these will greedily consume all tokens,
> including those for the next register. I am a bit at my wit's end here,
> but if you have an idea for how to do it nicely then by all means. :)

Actually I found a way to do it. V3 will support multiple register
definitions per invocation, thanks for the suggestion!