[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ca32359d08c642bd68133a8960315a80490f4da7.camel@pengutronix.de>
Date: Mon, 26 Jan 2026 08:23:19 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Anirudh Srinivasan <asrinivasan@....tenstorrent.com>
Cc: Drew Fustini <dfustini@....tenstorrent.com>, Joel Stanley
<jms@....tenstorrent.com>, Rob Herring <robh@...nel.org>, Krzysztof
Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Michael Turquette <mturquette@...libre.com>, Stephen Boyd
<sboyd@...nel.org>, linux-riscv@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-clk@...r.kernel.org, joel@....id.au, fustini@...nel.org,
mpe@...nel.org, mpe@....tenstorrent.com, npiggin@....tenstorrent.com,
agross@...nel.org, agross@....tenstorrent.com, bmasney@...hat.com
Subject: Re: [PATCH v2 2/3] reset: tenstorrent: Add reset controller for
Atlantis
On Fr, 2026-01-23 at 10:15 -0600, Anirudh Srinivasan wrote:
> > > +/* RCPU Reset Register Offsets */
> > > +#define RCPU_BLK_RST_REG 0x001c
> > > +#define LSIO_BLK_RST_REG 0x0020
> > > +#define HSIO_BLK_RST_REG 0x000c
> > > +#define PCIE_SUBS_RST_REG 0x0000
> > > +#define MM_RSTN_REG 0x0014
> >
> > Why not move these into reset-tenstorrent-atlantis.c, they are not part
> > of the interface between clock and reset drivers.
>
> We were considering putting register offsets like this in separate
> header files that are dual licensed. In that case, is it okay to put
> it here?
I see, nothing wrong with that.
regards
Philipp
Powered by blists - more mailing lists