linux-kernel - Re: [PATCH] ALSA: jack: Improve string handling in jack_kctl_name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87qzrcbwoi.wl-tiwai@suse.de>
Date: Mon, 26 Jan 2026 09:33:17 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: jack: Improve string handling in jack_kctl_name_gen

On Sun, 25 Jan 2026 16:51:56 +0100,
Thorsten Blum wrote:
> 
> If appending " Jack" is not necessary, replace snprintf("%s", ...) with
> the faster strscpy().
> 
> Additionally, rename 'need_cat' to the clearer 'append_suf', use local
> variables for the suffix and its length, remove the confusing comment,
> compare strncmp() to 0, and use 'size_t' for the 'size' function
> parameter.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Thanks, applied to for-next branch.


Takashi