linux-kernel - Re: 回复: [PATCH] scsi: mpt3sas: Fix invalid NUMA node index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43040a4e-c2e2-4f51-b4a0-13ebd546cf46@oracle.com>
Date: Mon, 26 Jan 2026 08:33:02 +0000
From: John Garry <john.g.garry@...cle.com>
To: "vulab@...as.ac.cn" <vulab@...as.ac.cn>
Cc: "sathya.prakash@...adcom.com" <sathya.prakash@...adcom.com>,
        "sreekanth.reddy@...adcom.com" <sreekanth.reddy@...adcom.com>,
        "suganath-prabu.subramani@...adcom.com"
 <suganath-prabu.subramani@...adcom.com>,
        "James.Bottomley@...senPartnership.com"
 <James.Bottomley@...senPartnership.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "MPT-FusionLinux.pdl@...adcom.com" <MPT-FusionLinux.pdl@...adcom.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: 回复: [PATCH] scsi: mpt3sas: Fix invalid NUMA node index

>>                  */
>>                 if (ioc->high_iops_queues) {
>> -                     mask = cpumask_of_node(dev_to_node(&ioc->pdev->dev));
>> +                     int nid = dev_to_node(&ioc->pdev->dev);
>> +
>> +                     if (nid == NUMA_NO_NODE)
>> +                             nid = 0;
>> +                     mask = cpumask_of_node(nid);
> 
> Some versions of cpumask_of_node() handle NUMA_NO_NODE gracefully and
> some don't.
> 
> For the core drivers/base/arch_numa.c version, it returns cpu_all_mask
> (for NUMA_NO_NODE) - so your behaviour here is different.

I sent a series to make all versions of cpumask_of_node() handle 
NUMA_NO_NODE:
https://lore.kernel.org/lkml/20260107094007.966496-1-john.g.garry@oracle.com/

Please check it and provide Tested-by/Reviewed-by tags if you are happy 
with it.

Thanks,
John