linux-kernel - Re: [PATCH] ALSA: lx6464es: fix a error handling in lx_hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87pl6wbwdm.wl-tiwai@suse.de>
Date: Mon, 26 Jan 2026 09:39:49 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	andriy.shevchenko@...ux.intel.com,
	phasta@...nel.org,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: lx6464es: fix a error handling in lx_hardware_open()

On Mon, 26 Jan 2026 02:18:54 +0100,
Haoxiang Li wrote:
> 
> In lx_hardware_open(), if lx_set_granularity() fails,
> call lx_pipe_release() to release the resoueces.
> 
> Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>

Thanks for the patch.  But beware that this isn't about the kernel
resource allocation or free, but rather the manipulation of the
chip-inside configuration.  So there is no memory leak or such.

And, this doesn't look like the only place that leads to the
unbalanced / unexpected configuration, and we might need to address
all...


Takashi

> ---
>  sound/pci/lx6464es/lx6464es.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c
> index 96df00db51d5..af8d614381b5 100644
> --- a/sound/pci/lx6464es/lx6464es.c
> +++ b/sound/pci/lx6464es/lx6464es.c
> @@ -113,6 +113,7 @@ static int lx_hardware_open(struct lx6464es *chip,
>  	if (err < 0) {
>  		dev_err(chip->card->dev, "setting granularity to %ld failed\n",
>  			   period_size);
> +		lx_pipe_release(chip, 0, is_capture);
>  		return err;
>  	}
>  
> -- 
> 2.25.1
>