[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aXdHk6qvotpHkILx@gmail.com>
Date: Mon, 26 Jan 2026 11:53:07 +0100
From: Marcus Folkesson <marcus.folkesson@...il.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: linux-kernel@...r.kernel.org, linux-rt-devel@...ts.linux.dev,
Thomas Gleixner <tglx@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Michael Hennerich <Michael.Hennerich@...log.com>,
Puranjay Mohan <puranjay@...nel.org>,
Jonathan Cameron <jic23@...nel.org>,
David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>,
Andy Shevchenko <andy@...nel.org>,
Marcelo Schmitt <marcelo.schmitt@...log.com>,
Kent Gustavsson <kent@...oris.se>,
Gustavo Silva <gustavograzs@...il.com>,
Nishant Malpani <nish.malpani25@...il.com>,
linux-iio@...r.kernel.org
Subject: Re: [PATCH 18/21] iio: Replace IRQF_ONESHOT with IRQF_NO_THREAD
On Fri, Jan 23, 2026 at 12:37:04PM +0100, Sebastian Andrzej Siewior wrote:
> Passing IRQF_ONESHOT ensures that the interrupt source is masked until
> the secondary (threaded) handler is done. If only a primary handler is
> used then the flag makes no sense because the interrupt can not fire
> (again) while its handler is running.
> The flag also disallows force-threading of the primary handler and the
> irq-core will warn about this.
>
> The intention here was probably not allowing forced-threading for
> handlers such as iio_trigger_generic_data_rdy_poll() will intends to
> invoke hard-interrupt handlers.
>
> Replace IRQF_ONESHOT with IRQF_NO_THREAD.
>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Cc: Michael Hennerich <Michael.Hennerich@...log.com>
> Cc: Puranjay Mohan <puranjay@...nel.org>
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: David Lechner <dlechner@...libre.com>
> Cc: "Nuno Sá" <nuno.sa@...log.com>
> Cc: Andy Shevchenko <andy@...nel.org>
> Cc: Marcelo Schmitt <marcelo.schmitt@...log.com>
> Cc: Marcus Folkesson <marcus.folkesson@...il.com>
> Cc: Kent Gustavsson <kent@...oris.se>
> Cc: Gustavo Silva <gustavograzs@...il.com>
> Cc: Nishant Malpani <nish.malpani25@...il.com>
> Cc: linux-iio@...r.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---
[...]
> drivers/iio/adc/mcp3911.c | 2 +-
Reviewed-by: Marcus Folkesson <marcus.folkesson@...il.com>
Best regards,
Marcus Folkesson
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists