linux-kernel - Re: [PATCH 17/21] mfd: wm8350-core: Use IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aXdP4xWP_Gu50Zog@smile.fi.intel.com>
Date: Mon, 26 Jan 2026 13:28:35 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: linux-kernel@...r.kernel.org, linux-rt-devel@...ts.linux.dev,
	Thomas Gleixner <tglx@...nel.org>, Lee Jones <lee@...nel.org>,
	patches@...nsource.cirrus.com, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 17/21] mfd: wm8350-core: Use IRQF_ONESHOT

On Mon, Jan 26, 2026 at 01:22:14PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 26, 2026 at 11:13:08AM +0100, Sebastian Andrzej Siewior wrote:
> > On 2026-01-26 12:05:13 [+0200], Andy Shevchenko wrote:

...

> > > > or will be imported via git-am.
> > > 
> > > Yes, that's the idea. `git am` will strip them out. But why would you need to
> > > apply via `git am` locally? You can pull from the tree.
> > 
> > I fetch from the list to pick up the tags, fix some of them up as the
> > iio but most of them remain the same. Then I post the v2. Where do I get
> > the Cc from? So I add them manually again?
> 
> Nope, I just checked how `b4 trailers -u ...` works. It does the correct thing.
> What did I miss?
> 
> So, for the matter of test I took this one:
> 20250503-smc-6-15-v4-1-500b9b6546fc@...npeter.dev
> (as a *single* change).
> 
> In my tree I corrected it to look like this at the end of the commit message:
> 
>     Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
>     Signed-off-by: Sven Peter <sven@...npeter.dev>
>     ---
>     Cc: Janne Grunau <j@...nau.net>
>     Cc: Alyssa Rosenzweig <alyssa@...enzweig.io>
>     Cc: Neal Gompa <neal@...pa.dev>
>     Cc: Hector Martin <marcan@...can.st>
>     Cc: Linus Walleij <linus.walleij@...aro.org>
>     Cc: Bartosz Golaszewski <brgl@...ev.pl>
>     Cc: Rob Herring <robh@...nel.org>
>     Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>
>     Cc: Conor Dooley <conor+dt@...nel.org>
>     Cc: Sebastian Reichel <sre@...nel.org>
>     Cc: Lee Jones <lee@...nel.org>
>     Cc: Marc Zyngier <maz@...nel.org>
>     Cc: asahi@...ts.linux.dev
>     Cc: linux-arm-kernel@...ts.infradead.org
>     Cc: linux-gpio@...r.kernel.org
>     Cc: devicetree@...r.kernel.org
>     Cc: linux-kernel@...r.kernel.org
>     Cc: linux-pm@...r.kernel.org
> 
> Then I ran
> 
> $ b4 trailers -u 20250503-smc-6-15-v4-1-500b9b6546fc@...npeter.dev
> Finding code-review trailers for 1 commits...
> ---
>   + Reviewed-by: Alyssa Rosenzweig <alyssa@...enzweig.io>
>     https://lore.kernel.org/all/aB3_Kw6WDaDAY6Ub@blossom
>   + Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>     https://lore.kernel.org/all/CACRpkdbCfUEZd06yeZTNecGFPwBgJkpMH3hqkvJw4J%2BiSENG%3DQ@mail.gmail.com
> ---
> Press Enter to apply these trailers or Ctrl-C to abort
>   dt-bindings: gpio: Add Apple Mac SMC GPIO block
>     + Reviewed-by: Alyssa Rosenzweig <alyssa@...enzweig.io> (✓ DKIM/rosenzweig.io)
>     + Reviewed-by: Linus Walleij <linus.walleij@...aro.org> (✗ DKIM/linaro.org)
> ---
> Invoking git-filter-repo to update trailers.
> New history written in 0.08 seconds...
> Completely finished after 0.38 seconds.
> Trailers updated.
> 
> Then I looked at `git show` again:
> 
>     Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
>     Signed-off-by: Sven Peter <sven@...npeter.dev>
>     Reviewed-by: Alyssa Rosenzweig <alyssa@...enzweig.io>
>     Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>     ---
>     Cc: Janne Grunau <j@...nau.net>
>     Cc: Alyssa Rosenzweig <alyssa@...enzweig.io>
>     Cc: Neal Gompa <neal@...pa.dev>
>     Cc: Hector Martin <marcan@...can.st>
>     Cc: Linus Walleij <linus.walleij@...aro.org>
>     Cc: Bartosz Golaszewski <brgl@...ev.pl>
>     Cc: Rob Herring <robh@...nel.org>
>     Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>
>     Cc: Conor Dooley <conor+dt@...nel.org>
>     Cc: Sebastian Reichel <sre@...nel.org>
>     Cc: Lee Jones <lee@...nel.org>
>     Cc: Marc Zyngier <maz@...nel.org>
>     Cc: asahi@...ts.linux.dev
>     Cc: linux-arm-kernel@...ts.infradead.org
>     Cc: linux-gpio@...r.kernel.org
>     Cc: devicetree@...r.kernel.org
>     Cc: linux-kernel@...r.kernel.org
>     Cc: linux-pm@...r.kernel.org

FWIW, I ran `git format-patch` and reapplied locally to test how maintainer
will see it:

    Add the DT binding for the Apple Mac System Management Controller GPIOs.

    Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
    Signed-off-by: Sven Peter <sven@...npeter.dev>
    Reviewed-by: Alyssa Rosenzweig <alyssa@...enzweig.io>
    Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

diff --git a/Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml b/Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml

So, everything works as intended.

> P.S. `git am` is for maintainers, not flexible for the contributors.
> 
> > > > If you continue to nitpick here, I could do it for the next iio
> > > > submission assuming it will be picked-up by iio maintainers. But doing
> > > > it just for the single mfd patch looks like too much work.
> > > 
> > > I'm thinking of all the patches.

-- 
With Best Regards,
Andy Shevchenko