linux-kernel - Re: [PATCH v2 1/2] rust: task: use `as_char_ptr` instead of `as

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DFYIOZVRU5FI.K45LLC9U4U0W@garyguo.net>
Date: Mon, 26 Jan 2026 12:25:03 +0000
From: "Gary Guo" <gary@...yguo.net>
To: "Alice Ryhl" <aliceryhl@...gle.com>, "Tamir Duberstein"
 <tamird@...nel.org>
Cc: "kernel test robot" <lkp@...el.com>, "Gary Guo" <gary@...nel.org>,
 "Miguel Ojeda" <ojeda@...nel.org>, "Boqun Feng" <boqun.feng@...il.com>,
 "Gary Guo" <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Trevor Gross" <tmgross@...ch.edu>,
 "Danilo Krummrich" <dakr@...nel.org>, "Panagiotis Foliadis"
 <pfoliadis@...teo.net>, "Shankari Anand" <shankari.ak0208@...il.com>,
 "FUJITA Tomonori" <fujita.tomonori@...il.com>, <llvm@...ts.linux.dev>,
 <oe-kbuild-all@...ts.linux.dev>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] rust: task: use `as_char_ptr` instead of
 `as_ptr().cast()`

On Mon Jan 26, 2026 at 9:22 AM GMT, Alice Ryhl wrote:
> On Sun, Jan 25, 2026 at 03:19:53PM -0500, Tamir Duberstein wrote:
>> On Sat, Jan 24, 2026 at 6:34 PM kernel test robot <lkp@...el.com> wrote:
>> >
>> > Hi Gary,
>> >
>> > kernel test robot noticed the following build warnings:
>> >
>> > [auto build test WARNING on 053966c344dbd346e71305f530e91ea77916189f]
>> >
>> > url:    https://github.com/intel-lab-lkp/linux/commits/Gary-Guo/rust-disallow-use-of-CStr-as_ptr/20260122-224657
>> > base:   053966c344dbd346e71305f530e91ea77916189f
>> > patch link:    https://lore.kernel.org/r/20260122144444.265412-1-gary%40kernel.org
>> > patch subject: [PATCH v2 1/2] rust: task: use `as_char_ptr` instead of `as_ptr().cast()`
>> > config: x86_64-buildonly-randconfig-004-20260125 (https://download.01.org/0day-ci/archive/20260125/202601250701.wXxtGd9z-lkp@intel.com/config)
>> > compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
>> > rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
>> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260125/202601250701.wXxtGd9z-lkp@intel.com/reproduce)
>> >
>> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> > the same patch/commit), kindly add following tags
>> > | Reported-by: kernel test robot <lkp@...el.com>
>> > | Closes: https://lore.kernel.org/oe-kbuild-all/202601250701.wXxtGd9z-lkp@intel.com/
>> >
>> > All warnings (new ones prefixed by >>):
>> >
>> > >> warning: unused import: `str::CStrExt`
>> >    --> rust/kernel/task.rs:12:5
>> >    |
>> >    12 |     str::CStrExt,
>> >    |     ^^^^^^^^^^^^
>> >    |
>> >    = note: `#[warn(unused_imports)]` on by default
>> 
>> Seems like the import needs to be conditional on
>> CONFIG_DEBUG_ATOMIC_SLEEP. Aside: it can also be `as _` since it isn't
>> named directly.
>
> Can we just import the prelude instead of having a conditional import?
>
> Alice

I'll do that in v2.

Best,
Gary