linux-kernel - Re: [PATCH v3 2/6] rust: num: add `shr` and `shl` methods to `Bounded`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kV4cXh6HfL2C1i0TJxWjFAZ3dqo+agBXt-yw9HWxKybA@mail.gmail.com>
Date: Mon, 26 Jan 2026 14:55:24 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Alexandre Courbot <acourbot@...dia.com>
Cc: Danilo Krummrich <dakr@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Daniel Almeida <daniel.almeida@...labora.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, Yury Norov <yury.norov@...il.com>, 
	John Hubbard <jhubbard@...dia.com>, Alistair Popple <apopple@...dia.com>, 
	Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi <ttabi@...dia.com>, Edwin Peer <epeer@...dia.com>, 
	Eliot Courtney <ecourtney@...dia.com>, Dirk Behme <dirk.behme@...bosch.com>, 
	Steven Price <steven.price@....com>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/6] rust: num: add `shr` and `shl` methods to `Bounded`

On Mon, Jan 26, 2026 at 2:29 PM Alexandre Courbot <acourbot@...dia.com> wrote:
>
> +        // SAFETY: we shift the value right by `SHIFT`, reducing the number of bits needed to

  // SAFETY: We

> +        // SAFETY: we shift the value left by `SHIFT`, augmenting the number of bits needed to

  // SAFETY: We

With the nits above:

Acked-by: Miguel Ojeda <ojeda@...nel.org>

Cheers,
Miguel