linux-kernel - Re: [PATCH v2] platform/x86: redmi-wmi: Add more hotkey mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0d6c973-7b00-48e6-bad6-f592b6e37a61@foxido.dev>
Date: Tue, 27 Jan 2026 16:50:50 +0300
From: Gladyshev Ilya <foxido@...ido.dev>
To: Jesse Guo <JesseGuoTech@...look.com>, Hans de Goede <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform/x86: redmi-wmi: Add more hotkey mappings

On 1/25/26 23:48, Jesse Guo wrote:
> This patch adds more Fn hotkeys (like Refresh rate toggle).
> Additionally, remap the setup key from KEY_SETUP to KEY_CONFIG.
> As KEY_CONFIG is supported by Desktop Environments for launching
> system settings, whereas KEY_SETUP is often ignored by userspace.
> 
> Signed-off-by: Jesse Guo <JesseGuoTech@...look.com>
> ---
> Changes in v2:
> - Dropped Fn Lock (KEY_FN_ESC) mapping to avoid potential user confusion.
> - The Fn Lock state is handled internally by the EC and does not require
>    a dedicated key event. (Suggested by Gladyshev Ilya)
> - Link to v1: https://lore.kernel.org/r/20260125-redmi-wmi-hotkey-add-v1-1-d3e28568dd75@outlook.com
> ---
>   drivers/platform/x86/redmi-wmi.c | 25 ++++++++++++++++++++++++-
>   1 file changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/redmi-wmi.c b/drivers/platform/x86/redmi-wmi.c
> index 949236b93a321a943a9cb8b0528d730dbaa2cd6f..e5cb348e3a39a3e17abe6b729c79a9f3220eebd6 100644
> --- a/drivers/platform/x86/redmi-wmi.c
> +++ b/drivers/platform/x86/redmi-wmi.c
> @@ -20,7 +20,10 @@
>   static const struct key_entry redmi_wmi_keymap[] = {
>   	{KE_KEY, 0x00000201,	{KEY_SELECTIVE_SCREENSHOT}},
>   	{KE_KEY, 0x00000301,	{KEY_ALL_APPLICATIONS}},
> -	{KE_KEY, 0x00001b01,	{KEY_SETUP}},
> +	{KE_KEY, 0x00001b01,	{KEY_CONFIG}},
> +	{KE_KEY, 0x00011b01,	{KEY_CONFIG}},
> +	{KE_KEY, 0x00010101,	{KEY_SWITCHVIDEOMODE}},
> +	{KE_KEY, 0x00001a01,	{KEY_REFRESH_RATE_TOGGLE}},
>   
>   	/* AI button has code for each position */
>   	{KE_KEY, 0x00011801,	{KEY_ASSISTANT}},
> @@ -32,6 +35,26 @@ static const struct key_entry redmi_wmi_keymap[] = {
>   	{KE_IGNORE, 0x00050501, {}},
>   	{KE_IGNORE, 0x000a0501, {}},
>   
> +	/* Xiaomi G Command Center */
> +	{KE_KEY, 0x00010a01,	{KEY_VENDOR}},
> +
> +	/* OEM preset power mode */
> +	{KE_IGNORE, 0x00011601, {}},
> +	{KE_IGNORE, 0x00021601, {}},
> +	{KE_IGNORE, 0x00031601, {}},
> +	{KE_IGNORE, 0x00041601, {}},
> +
> +	/* Fn Lock state */
> +	{KE_IGNORE, 0x00000701, {}},
> +	{KE_IGNORE, 0x00010701, {}},
> +
> +	/* Fn+`/1/2/3/4 */
> +	{KE_KEY, 0x00011101, {KEY_F13}},
> +	{KE_KEY, 0x00011201, {KEY_F14}},
> +	{KE_KEY, 0x00011301, {KEY_F15}},
> +	{KE_KEY, 0x00011401, {KEY_F16}},
> +	{KE_KEY, 0x00011501, {KEY_F17}},
> +
>   	{KE_END}
>   };
>   

LGTM

Reviewed-by: Gladyshev Ilya <foxido@...ido.dev>

> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20260125-redmi-wmi-hotkey-add-666af84b0eeb
> 
> Best regards,