linux-kernel - RE: [PATCH] mailbox: Clean up the usage of mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8459042676EF3E77D71C19428890A@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Tue, 27 Jan 2026 13:51:41 +0000
From: Peng Fan <peng.fan@....com>
To: Sudeep Holla <sudeep.holla@...nel.org>, "Peng Fan (OSS)"
	<peng.fan@....nxp.com>
CC: Jassi Brar <jassisinghbrar@...il.com>, Beleswar Padhi <b-padhi@...com>,
	Andrew Davis <afd@...com>, Yuntao Dai <d1581209858@...e.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"mailbox@...ts.linux.dev" <mailbox@...ts.linux.dev>
Subject: RE: [PATCH] mailbox: Clean up the usage of mailbox_client.h

Hi Sudeep,

> Subject: Re: [PATCH] mailbox: Clean up the usage of mailbox_client.h
> 
> On Tue, Jan 27, 2026 at 07:02:53AM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> > mailbox_client.h is should be used by consumer drivers, not mailbox
> > provider.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> >  drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
> >  drivers/mailbox/cv1800-mailbox.c     | 1 -
> >  drivers/mailbox/omap-mailbox.c       | 1 -
> >  drivers/mailbox/pcc.c                | 1 -
> >  4 files changed, 4 deletions(-)
> >
> 
> [...]
> 
> >
> > diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c index
> >
> 22e70af1ae5d14e6e8c684fe032c2864f6ae4d6c..6ca84596e7637114f6
> 6d32a95d12
> > c863e942b756 100644
> > --- a/drivers/mailbox/pcc.c
> > +++ b/drivers/mailbox/pcc.c
> > @@ -55,7 +55,6 @@
> >  #include <linux/log2.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/mailbox_controller.h> -#include
> > <linux/mailbox_client.h>  #include <linux/io-64-nonatomic-lo-hi.h>
> > #include <acpi/pcc.h>
> >
> 
> There is a call to mbox_bind_client() in pcc.c that is declared in
> linux/mailbox_client.h

Thanks for raising this.

> 
> You didn't see any build warning or errors with this change ? 

I not see build warning or errors with aarch64 yocto scarthgap
toolchain. Log as below:

~/l/linux-next (b4/mailbox-v1)> ./build.sh
*** Default configuration is based on 'defconfig'
#
# No change to .config
#
  CALL    scripts/checksyscalls.sh
  CC      drivers/mailbox/mailbox.o
  CC      drivers/mailbox/arm_mhu.o
  CC      drivers/mailbox/arm_mhu_db.o
  CC      drivers/mailbox/imx-mailbox.o
  CC      drivers/mailbox/platform_mhu.o
  CC      drivers/mailbox/pcc.o
  CC      drivers/mailbox/bcm2835-mailbox.o

Esp if
> build as module.

CONFIG_PCC could not be select as module.

TBH, per my understanding, pcc_mbox_request_channel
should be implemented in consumer driver.
drivers/mailbox/ is for mailbox controller.

Regards
Peng.

> 
> --
> Regards,
> Sudeep