linux-kernel - Re: [PATCH 2/2] misc: ti_fpc202: Support special-purpose GPIO lines with LED features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1bae4f71-9688-4e6c-8025-920dc20cdf88@app.fastmail.com>
Date: Tue, 27 Jan 2026 15:03:48 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Romain Gantois" <romain.gantois@...tlin.com>,
 "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Conor Dooley" <conor+dt@...nel.org>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@...tlin.com>,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] misc: ti_fpc202: Support special-purpose GPIO lines with LED
 features

On Tue, Jan 27, 2026, at 14:51, Romain Gantois wrote:
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -118,6 +118,7 @@ config TI_FPC202
>  	depends on I2C
>  	select GPIOLIB
>  	select I2C_ATR
> +	select LEDS_CLASS
>  	help
>  	  If you say yes here you get support for the Texas Instruments FPC202
>  	  Dual Port Controller.

Selecting a foreign subsystem is usually a bad idea, as it
leads to dependency loops.

For LEDS_CLASS, I think this needs to be 'depends on LEDS_CLASS',
or possibly 'depends on LEDS_CLASS || !LEDS_CLASS' if you want
to keep that optional.

I would also change the GPIOLIB dependency the same way, but that
should be a separate patch of course.

     Arnd