linux-kernel - Re: [PATCH] usb: typec: hd3ss3220: Check if regulator needs to be switched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026012754-trump-coziness-cda1@gregkh>
Date: Tue, 27 Jan 2026 15:21:10 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Jan Remmet <J.Remmet@...tec.de>
Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Krishna Kurapati <krishna.kurapati@....qualcomm.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"upstream@...ts.phytec.de" <upstream@...ts.phytec.de>
Subject: Re: [PATCH] usb: typec: hd3ss3220: Check if regulator needs to be
 switched

On Mon, Jan 26, 2026 at 03:22:01PM +0000, Jan Remmet wrote:
> Am 26.01.26 um 15:32 schrieb Heikki Krogerus:
> > Mon, Jan 26, 2026 at 01:06:36PM +0100, Jan Remmet kirjoitti:
> >> Check regulator state as peripheral and detach can disable vbus.
> >> Without this check we will try to disable the regulator twice if
> >> we disconnect host and then connect as device.
> >>
> >> Signed-off-by: Jan Remmet <j.remmet@...tec.de>
> >> ---
> >> This is a fixup from
> >> - Link to v1: https://lore.kernel.org/r/20260115-wip-jremmet-hd3ss3220_vbus-v1-1-b7d9adfbe346@phytec.de
> >> To
> >> - Link to v2: https://lore.kernel.org/r/20260123-wip-jremmet-hd3ss3220_vbus-v2-1-bcad313ce92b@phytec.de
> > 
> > I don't understand that, but I think you are fixing a commit in Greg's
> > tree, right?
> Yes
> > 
> > If that's the case, then you need the Fixes tag.
> 
> Sorry, I'm not familar with the workflow here. Should it be a "--fixup" 
> git commit against the usb-next commit id?
> 
> Or
> Fixes: 7e7025811579 ("usb: typec: hd3ss3220: Check if regulator needs to 
> be switched")
> 
> In the commit message (again with commit sha from Greg's usb-next

This one, Fixes: is the correct way to do it.

thanks,

greg k-h