linux-kernel - Re: [PATCH] pmdomain: ti: omap_prm: Fix a reference leak on device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFqCewZeQV6UVGXXuuxjPa_amThaHz0TmLpLksP1A=G9Eg@mail.gmail.com>
Date: Tue, 27 Jan 2026 15:27:07 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Felix Gu <gu_0233@...com>
Cc: Nishanth Menon <nm@...com>, Santosh Shilimkar <ssantosh@...nel.org>, Tony Lindgren <tony@...mide.com>, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-pm@...r.kernel.org
Subject: Re: [PATCH] pmdomain: ti: omap_prm: Fix a reference leak on device node

On Fri, 16 Jan 2026 at 13:27, Felix Gu <gu_0233@...com> wrote:
>
> When calling of_parse_phandle_with_args(), the caller is responsible
> to call of_node_put() to release the reference of device node.
> In omap_prm_domain_attach_dev, it does not release the reference.
>
> Fixes: 58cbff023bfa ("soc: ti: omap-prm: Add basic power domain support")
> Signed-off-by: Felix Gu <gu_0233@...com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/pmdomain/ti/omap_prm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pmdomain/ti/omap_prm.c b/drivers/pmdomain/ti/omap_prm.c
> index 5142f064bf5c..64a187f79a1a 100644
> --- a/drivers/pmdomain/ti/omap_prm.c
> +++ b/drivers/pmdomain/ti/omap_prm.c
> @@ -655,6 +655,7 @@ static int omap_prm_domain_attach_dev(struct generic_pm_domain *domain,
>         if (pd_args.args_count != 0)
>                 dev_warn(dev, "%s: unusupported #power-domain-cells: %i\n",
>                          prmd->pd.name, pd_args.args_count);
> +       of_node_put(pd_args.np);
>
>         genpd_data = dev_gpd_data(dev);
>         genpd_data->data = NULL;
>
> ---
> base-commit: 9b7977f9e39b7768c70c2aa497f04e7569fd3e00
> change-id: 20260116-omap_prm-c7bdd9726abc
>
> Best regards,
> --
> Felix Gu <gu_0233@...com>
>