linux-kernel - Re: [PATCH 2/2] interconnect: qcom: Add Eliza interconnect provider driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jvvj6eehw3gxthrldtafc26xua4ai7nheojfdflbgabjwxbdxl@ymrgczsq4zhy>
Date: Tue, 27 Jan 2026 16:32:08 +0200
From: Abel Vesa <abel.vesa@....qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Georgi Djakov <djakov@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Odelu Kukatla <odelu.kukatla@....qualcomm.com>,
        linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] interconnect: qcom: Add Eliza interconnect provider
 driver

On 26-01-26 11:26:07, Konrad Dybcio wrote:
> On 1/23/26 1:43 PM, Abel Vesa wrote:
> > From: Odelu Kukatla <odelu.kukatla@....qualcomm.com>
> > 
> > Add driver for the Qualcomm interconnect buses found in Eliza
> > based platforms. The topology consists of several NoCs that are
> > controlled by a remote processor that collects the aggregated
> > bandwidth for each master-slave pairs.
> > 
> > Signed-off-by: Odelu Kukatla <odelu.kukatla@....qualcomm.com>
> > Signed-off-by: Abel Vesa <abel.vesa@....qualcomm.com>
> > ---
> 
> [...]
> 
> >  drivers/interconnect/qcom/Kconfig  |    9 +
> >  drivers/interconnect/qcom/Makefile |    2 +
> >  drivers/interconnect/qcom/eliza.c  | 1586 ++++++++++++++++++++++++++++++++++++
> >  3 files changed, 1597 insertions(+)
> > 
> > diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
> > index bb1cb8a640c1..53398e972458 100644
> > --- a/drivers/interconnect/qcom/Kconfig
> > +++ b/drivers/interconnect/qcom/Kconfig
> > @@ -8,6 +8,15 @@ config INTERCONNECT_QCOM
> >  config INTERCONNECT_QCOM_BCM_VOTER
> >  	tristate
> >  
> > +config INTERCONNECT_QCOM_ELIZA
> > +       tristate "Qualcomm ELIZA interconnect driver"
> 
> Please don't scream

But this would make it "the one-off" though...
All other ones are all caps. :-)

> 
> > +       depends on INTERCONNECT_QCOM_RPMH_POSSIBLE
> > +       select INTERCONNECT_QCOM_RPMH
> > +       select INTERCONNECT_QCOM_BCM_VOTER
> > +       help
> > +         This is a driver for the Qualcomm Network-on-Chip on eliza-based
> 
> Whispering afterwards is odd too

Will fix.

> 
> [...]
> 
> > +++ b/drivers/interconnect/qcom/eliza.c
> > @@ -0,0 +1,1586 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> > + *
> > + */
> 
> Stray empty comment line above

Will drop.

> 
> [...]
> 
> > +MODULE_DESCRIPTION(" Qualcomm ELIZA NoC driver");
> 
> Please don't scream

Yep, this one needs to be "Eliza". Will fix.

> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> 
> Konrad
>