linux-kernel - Re: [PATCH] firmware: imx: scu-pd: Fix device_node reference leak in imx_sc_pd_get_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFr+USco=KMAnQWz8J_VkqftYwKFV9QtRN0vyc=ERJK8ew@mail.gmail.com>
Date: Tue, 27 Jan 2026 15:27:13 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Felix Gu <ustc.gu@...il.com>
Cc: Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, 
	Dong Aisheng <aisheng.dong@....com>, linux-pm@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: imx: scu-pd: Fix device_node reference leak in imx_sc_pd_get_console_rsrc()

On Wed, 21 Jan 2026 at 15:17, Felix Gu <ustc.gu@...il.com> wrote:
>
> When calling of_parse_phandle_with_args(), the caller is responsible
> to call of_node_put() to release the reference of device node.
> In imx_sc_pd_get_console_rsrc(), it does not release the reference.
>
> Fixes: 893cfb99734f ("firmware: imx: scu-pd: do not power off console domain")
> Signed-off-by: Felix Gu <ustc.gu@...il.com>

Applied for next by amending the commit-msg-header, thanks!

Kind regards
Uffe



> ---
>  drivers/pmdomain/imx/scu-pd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pmdomain/imx/scu-pd.c b/drivers/pmdomain/imx/scu-pd.c
> index 01d465d88f60..3ec33667a308 100644
> --- a/drivers/pmdomain/imx/scu-pd.c
> +++ b/drivers/pmdomain/imx/scu-pd.c
> @@ -326,6 +326,7 @@ static void imx_sc_pd_get_console_rsrc(void)
>                 return;
>
>         imx_con_rsrc = specs.args[0];
> +       of_node_put(specs.np);
>  }
>
>  static int imx_sc_get_pd_power(struct device *dev, u32 rsrc)
>
> ---
> base-commit: 053966c344dbd346e71305f530e91ea77916189f
> change-id: 20260121-b4-scu-pd-257a9a40e84e
>
> Best regards,
> --
> Felix Gu <ustc.gu@...il.com>
>