linux-kernel - Re: [PATCH v2 4/4] staging: rtl8723bs: fix line length check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026012713-bovine-tricolor-d747@gregkh>
Date: Tue, 27 Jan 2026 15:40:31 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Mahad Ibrahim <mahad.ibrahim.dev@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] staging: rtl8723bs: fix line length check

On Sun, Jan 18, 2026 at 04:54:45PM +0500, Mahad Ibrahim wrote:
> Fix checkpatch.pl check regarding:
> - Line length of X exceeds 100 columns
> 
> Redistribute comments to multiple lines to adhere to kernel coding
> standards.
> 
> Signed-off-by: Mahad Ibrahim <mahad.ibrahim.dev@...il.com>
> ---
>  drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
> index b7176a992518..fb108492efac 100644
> --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
> +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
> @@ -60,7 +60,8 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const u32 Condition1, const
>  		if ((cond1 & BIT3) != 0) /* APA */
>  			bitMask |= 0xFF000000;
>  
> -		if ((cond2 & bitMask) == (driver2 & bitMask)) /*  BoardType of each RF path is matched */
> +		/*  BoardType of each RF path is matched */

Why the extra space after /* and before BoardType?

thanks,

greg k-h