linux-kernel - Re: [PATCH v7 0/2] staging: rtl8723bs: Fix error handling in _rtw_pktfile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026012749-saffron-untoasted-80ee@gregkh>
Date: Tue, 27 Jan 2026 15:48:00 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Minu Jin <s9430939@...er.com>
Cc: andriy.shevchenko@...ux.intel.com, dan.carpenter@...aro.org,
	abrahamadekunle50@...il.com, zxcv2569763104@...il.com,
	milospuric856@...il.com, karanja99erick@...il.com,
	weibu@...admin.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 0/2] staging: rtl8723bs: Fix error handling in
 _rtw_pktfile_read()

On Tue, Jan 27, 2026 at 01:34:28AM +0900, Minu Jin wrote:
> This series improves error handling in _rtw_pktfile_read() and cleans up
> the code style to comply with kernel standards.
> 
> 1. The first patch combines the logic change and caller updates.
>    The function change and the caller updates must be in the same
>    patch. If they are separated, the code will not work correctly 
>    or will cause errors at that specific point in the history.
> 
> 2. The second patch focuses purely on code style cleanup (changing uint
>    to unsigned int) as requested by Andy Shevchenko.
> 
> Regarding the logic change in _rtw_pktfile_read():
> 
>     The original code used a ternary operator to read whatever data was 
>     available, even if it was less than requested. This could lead to 
>     callers processing incomplete data without knowing it.
> 
>     I have changed this to return -EINVAL when the remaining data is insufficient. 
>     This is safer because most callers expect the exact amount of data and 
>     should not proceed with a partial read.
> 
> Testing and Verification:
> 
>     I do not have access to the physical RTL8723BS hardware. However, I have
>     performed a rigorous manual audit of the data path and verified the
>     changes using Smatch static analysis. The analysis confirmed that no
>     new warnings or logical regressions were introduced in the modified files.
> 
> Changes in v7:
>     - Added full cumulative changelog from v2 to v7 as requested by Greg KH.
>     - Added note regarding hardware testing and Smatch verification results.
> 
> Changes in v6:
>    - Reorganized into a 2-patch series to maintain git bisect safety
>      (addressed Dan Carpenter's feedback).
>    - Combined function logic changes with caller updates into Patch 1.
>    - Separated style cleanup (uint -> unsigned int) into Patch 2.
> 
> Changes in v5:
>    - Split the patch into a 3-patch series (suggested by Greg KH).
>    - Patch 1: Refactored return type to 'int'.
>    - Patch 2: Added error checks to call sites.
>    - Patch 3: Implemented -EINVAL logic.
>    (Note: Superseded by v6 to fix git bisect issues).
> 
> Changes in v4:
>    - Modified _rtw_pktfile_read() to return -EINVAL if data is
>      insufficient (following Greg KH's hint).
>    - Replaced 'uint' with 'unsigned int' (suggested by Andy Shevchenko).
>    - Removed redundant local variable 'len'.
> 
> Changes in v3:
>    - Updated set_qos() from void to int (suggested by Greg KH, Dan Carpenter).
>    - Fixed coding style issues (suggested by Andy Shevchenko).
> 
> Changes in v2:
>    - Added check for skb_copy_bits() return value.
> 
> -- 
> 2.43.0
> 
> 

Does not apply to my tree, please rebase and resend.

thanks,

greg k-h