linux-kernel - Re: [PATCH v2 2/2] hwmon: Add support for HiTRON HAC300S PSU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19d5da08-5605-414a-a1f3-2849b9bff19b@roeck-us.net>
Date: Tue, 27 Jan 2026 07:19:11 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
	Vasileios Amoiridis <vasileios.amoiridis@...n.ch>
Subject: Re: [PATCH v2 2/2] hwmon: Add support for HiTRON HAC300S PSU

On Mon, Jan 19, 2026 at 08:08:06PM +0100, Vasileios Amoiridis wrote:
> From: Vasileios Amoiridis <vasileios.amoiridis@...n.ch>
> 
> Add Support for HiTRON HAC300S PSU. This is a AC/DC hot-swappable
> CompactPCI Serial Dual output active current sharing switching power
> supply with a 312W rating.
> 
> Signed-off-by: Vasileios Amoiridis <vasileios.amoiridis@...n.ch>

checkpatch --strict returns various whitespace errors. Please run that
command in the future.

Also,

> +static int hac300s_read_byte_data(struct i2c_client *client, int page, int reg)
> +{
> +	const struct pmbus_driver_info *info = pmbus_get_driver_info(client);
> +	struct hac300s_data *data = to_hac300s_data(info);
> +
> +	if (reg == PMBUS_VOUT_MODE)
> +		return data->exponent;
> +
> +	return pmbus_read_byte_data(client, page, reg);

This should return -ENODATA.

No need to resend; I fixed it all up and applied the patch.

Thanks,
Guenter