linux-kernel - Re: [PATCH] phy: marvell: phy-mvebu-cp110-comphy: Remove unnecessary NULL check before clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa1ed8c5-a424-4585-914d-6d2b5b27b44a@web.de>
Date: Tue, 27 Jan 2026 16:16:19 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Chen Ni <nichen@...as.ac.cn>, linux-phy@...ts.infradead.org,
 Neil Armstrong <neil.armstrong@...aro.org>, Vinod Koul <vkoul@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: marvell: phy-mvebu-cp110-comphy: Remove unnecessary
 NULL check before clk_disable_unprepare()

> clk_disable_unprepare() already checks NULL by using IS_ERR_OR_NULL.

This function calls further functions which perform known input parameter validation.


> Remove unneeded NULL check for clk here.

May two blank lines be omitted accordingly?

Regards,
Markus