linux-kernel - Re: [PATCH v2 12/13] i2c: fsi: Convert to fsi bus probe mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfaf48f2-2da4-4fdd-8a13-3d1e4edfe70c@linux.ibm.com>
Date: Tue, 27 Jan 2026 09:29:16 -0600
From: Eddie James <eajames@...ux.ibm.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Ninad Palsule <ninad@...ux.ibm.com>, linux-fsi@...ts.ozlabs.org,
        Andi Shyti <andi.shyti@...nel.org>, linux-i2c@...r.kernel.org,
        openbmc@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 12/13] i2c: fsi: Convert to fsi bus probe mechanism


On 12/9/25 5:40 AM, Uwe Kleine-König wrote:
> The fsi bus got a dedicated probe function. Make use of that. This fixes
> a runtime warning about the driver needing to be converted to the bus
> probe method.


Acked-by: Eddie James <eajames@...ux.ibm.com>


>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> Reviewed-by: Andi Shyti <andi.shyti@...nel.org>
> ---
>   drivers/i2c/busses/i2c-fsi.c | 15 +++++++--------
>   1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c
> index e98dd5dcac0f..3a7e577e6eac 100644
> --- a/drivers/i2c/busses/i2c-fsi.c
> +++ b/drivers/i2c/busses/i2c-fsi.c
> @@ -674,8 +674,9 @@ static struct device_node *fsi_i2c_find_port_of_node(struct device_node *fsi,
>   	return NULL;
>   }
>   
> -static int fsi_i2c_probe(struct device *dev)
> +static int fsi_i2c_probe(struct fsi_device *fsi_dev)
>   {
> +	struct device *dev = &fsi_dev->dev;
>   	struct fsi_i2c_ctrl *i2c;
>   	struct fsi_i2c_port *port;
>   	struct device_node *np;
> @@ -735,14 +736,14 @@ static int fsi_i2c_probe(struct device *dev)
>   		list_add(&port->list, &i2c->ports);
>   	}
>   
> -	dev_set_drvdata(dev, i2c);
> +	fsi_set_drvdata(fsi_dev, i2c);
>   
>   	return 0;
>   }
>   
> -static int fsi_i2c_remove(struct device *dev)
> +static void fsi_i2c_remove(struct fsi_device *fsi_dev)
>   {
> -	struct fsi_i2c_ctrl *i2c = dev_get_drvdata(dev);
> +	struct fsi_i2c_ctrl *i2c = fsi_get_drvdata(fsi_dev);
>   	struct fsi_i2c_port *port, *tmp;
>   
>   	list_for_each_entry_safe(port, tmp, &i2c->ports, list) {
> @@ -750,8 +751,6 @@ static int fsi_i2c_remove(struct device *dev)
>   		i2c_del_adapter(&port->adapter);
>   		kfree(port);
>   	}
> -
> -	return 0;
>   }
>   
>   static const struct fsi_device_id fsi_i2c_ids[] = {
> @@ -761,10 +760,10 @@ static const struct fsi_device_id fsi_i2c_ids[] = {
>   
>   static struct fsi_driver fsi_i2c_driver = {
>   	.id_table = fsi_i2c_ids,
> +	.probe = fsi_i2c_probe,
> +	.remove = fsi_i2c_remove,
>   	.drv = {
>   		.name = "i2c-fsi",
> -		.probe = fsi_i2c_probe,
> -		.remove = fsi_i2c_remove,
>   	},
>   };
>