linux-kernel - Re: [PATCH v2 08/13] fsi: i2cr-scom: Convert to fsi bus probe mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db1d9516-37b7-4ba4-a75d-eb843180d53b@linux.ibm.com>
Date: Tue, 27 Jan 2026 09:27:29 -0600
From: Eddie James <eajames@...ux.ibm.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Ninad Palsule <ninad@...ux.ibm.com>, linux-fsi@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 08/13] fsi: i2cr-scom: Convert to fsi bus probe
 mechanism


On 12/9/25 5:40 AM, Uwe Kleine-König wrote:
> The fsi bus got a dedicated probe and remove callback. Make use of them.
> This fixes a runtime warning about the driver needing to be converted to
> the bus methods.


Acked-by: Eddie James <eajames@...ux.ibm.com>


>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
>   drivers/fsi/i2cr-scom.c | 14 ++++++--------
>   1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/fsi/i2cr-scom.c b/drivers/fsi/i2cr-scom.c
> index dfdb16afd205..3efca2e944bb 100644
> --- a/drivers/fsi/i2cr-scom.c
> +++ b/drivers/fsi/i2cr-scom.c
> @@ -81,9 +81,9 @@ static const struct file_operations i2cr_scom_fops = {
>   	.write		= i2cr_scom_write,
>   };
>   
> -static int i2cr_scom_probe(struct device *dev)
> +static int i2cr_scom_probe(struct fsi_device *fsi_dev)
>   {
> -	struct fsi_device *fsi_dev = to_fsi_dev(dev);
> +	struct device *dev = &fsi_dev->dev;
>   	struct i2cr_scom *scom;
>   	int didx;
>   	int ret;
> @@ -115,14 +115,12 @@ static int i2cr_scom_probe(struct device *dev)
>   	return ret;
>   }
>   
> -static int i2cr_scom_remove(struct device *dev)
> +static void i2cr_scom_remove(struct fsi_device *fsi_dev)
>   {
> -	struct i2cr_scom *scom = dev_get_drvdata(dev);
> +	struct i2cr_scom *scom = dev_get_drvdata(&fsi_dev->dev);
>   
>   	cdev_device_del(&scom->cdev, &scom->dev);
>   	fsi_free_minor(scom->dev.devt);
> -
> -	return 0;
>   }
>   
>   static const struct of_device_id i2cr_scom_of_ids[] = {
> @@ -137,12 +135,12 @@ static const struct fsi_device_id i2cr_scom_ids[] = {
>   };
>   
>   static struct fsi_driver i2cr_scom_driver = {
> +	.probe = i2cr_scom_probe,
> +	.remove = i2cr_scom_remove,
>   	.id_table = i2cr_scom_ids,
>   	.drv = {
>   		.name = "i2cr_scom",
>   		.of_match_table = i2cr_scom_of_ids,
> -		.probe = i2cr_scom_probe,
> -		.remove = i2cr_scom_remove,
>   	}
>   };
>