linux-kernel - Re: [PATCH] mailbox: Clean up the usage of mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXjhJzfHvxrP-zc7@bogus>
Date: Tue, 27 Jan 2026 16:00:39 +0000
From: Sudeep Holla <sudeep.holla@...nel.org>
To: Peng Fan <peng.fan@....com>
Cc: "Peng Fan (OSS)" <peng.fan@....nxp.com>,
	Sudeep Holla <sudeep.holla@...nel.org>,
	Jassi Brar <jassisinghbrar@...il.com>,
	Beleswar Padhi <b-padhi@...com>, Andrew Davis <afd@...com>,
	Yuntao Dai <d1581209858@...e.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"mailbox@...ts.linux.dev" <mailbox@...ts.linux.dev>
Subject: Re: [PATCH] mailbox: Clean up the usage of mailbox_client.h

On Tue, Jan 27, 2026 at 02:47:33PM +0000, Peng Fan wrote:
> > Subject: RE: [PATCH] mailbox: Clean up the usage of mailbox_client.h
> > 
> > Hi Sudeep,
> > 
> > > Subject: Re: [PATCH] mailbox: Clean up the usage of mailbox_client.h
> > >
> > > On Tue, Jan 27, 2026 at 07:02:53AM +0800, Peng Fan (OSS) wrote:
> > > > From: Peng Fan <peng.fan@....com>
> > > >
> > > > mailbox_client.h is should be used by consumer drivers, not
> > mailbox
> > > > provider.
> > > >
> > > > Signed-off-by: Peng Fan <peng.fan@....com>
> > > > ---
> > > >  drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
> > > >  drivers/mailbox/cv1800-mailbox.c     | 1 -
> > > >  drivers/mailbox/omap-mailbox.c       | 1 -
> > > >  drivers/mailbox/pcc.c                | 1 -
> > > >  4 files changed, 4 deletions(-)
> > > >
> > >
> > > [...]
> > >
> > > >
> > > > diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c index
> > > >
> > >
> > 22e70af1ae5d14e6e8c684fe032c2864f6ae4d6c..6ca84596e7637114f6
> > > 6d32a95d12
> > > > c863e942b756 100644
> > > > --- a/drivers/mailbox/pcc.c
> > > > +++ b/drivers/mailbox/pcc.c
> > > > @@ -55,7 +55,6 @@
> > > >  #include <linux/log2.h>
> > > >  #include <linux/platform_device.h>
> > > >  #include <linux/mailbox_controller.h> -#include
> > > > <linux/mailbox_client.h>  #include <linux/io-64-nonatomic-lo-hi.h>
> > > > #include <acpi/pcc.h>
> > > >
> > >
> > > There is a call to mbox_bind_client() in pcc.c that is declared in
> > > linux/mailbox_client.h
> > 
> > Thanks for raising this.
> 
> Check again.
> 
> include/acpi/pcc.h includes mailbox_client.h
> 

I see, I missed that. I’m fine with removing it, but the commit message
doesn’t really apply here since it’s getting included anyway. I don’t see
much point in removing it, but I’m fine either way.
-- 
Regards,
Sudeep