[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4bcd55a1-da5f-4161-aadf-594724c76627@nvidia.com>
Date: Wed, 28 Jan 2026 00:41:01 +0530
From: Sumit Gupta <sumitg@...dia.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: viresh.kumar@...aro.org, pierre.gondois@....com, zhenglifeng1@...wei.com,
ionela.voinescu@....com, lenb@...nel.org, robert.moore@...el.com,
corbet@....net, rdunlap@...radead.org, ray.huang@....com,
gautham.shenoy@....com, mario.limonciello@....com, perry.yuan@....com,
zhanjie9@...ilicon.com, linux-pm@...r.kernel.org,
linux-acpi@...r.kernel.org, linux-doc@...r.kernel.org,
acpica-devel@...ts.linux.dev, linux-kernel@...r.kernel.org,
linux-tegra@...r.kernel.org, treding@...dia.com, jonathanh@...dia.com,
vsethi@...dia.com, ksitaraman@...dia.com, sanjayc@...dia.com,
nhartman@...dia.com, bbasu@...dia.com, sumitg@...dia.com
Subject: Re: [PATCH v6 2/9] ACPI: CPPC: Clean up cppc_perf_caps and
cppc_perf_ctrls structs
On 27/01/26 21:57, Rafael J. Wysocki wrote:
> External email: Use caution opening links or attachments
>
>
> On Tue, Jan 20, 2026 at 3:57 PM Sumit Gupta <sumitg@...dia.com> wrote:
>> - Remove redundant energy_perf field from 'struct cppc_perf_caps' as
>> the same is available in 'struct cppc_perf_ctrls' which is used.
>> - Move the 'auto_sel' field from 'struct cppc_perf_caps' to
>> 'struct cppc_perf_ctrls' as it represents a control register.
>>
>> Reviewed-by: Pierre Gondois <pierre.gondois@....com>
>> Signed-off-by: Sumit Gupta <sumitg@...dia.com>
>> ---
>> include/acpi/cppc_acpi.h | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/include/acpi/cppc_acpi.h b/include/acpi/cppc_acpi.h
>> index 4bcdcaf8bf2c..6573a759eb8d 100644
>> --- a/include/acpi/cppc_acpi.h
>> +++ b/include/acpi/cppc_acpi.h
>> @@ -119,8 +119,6 @@ struct cppc_perf_caps {
>> u32 lowest_nonlinear_perf;
>> u32 lowest_freq;
>> u32 nominal_freq;
>> - u32 energy_perf;
>> - bool auto_sel;
>> };
>>
>> struct cppc_perf_ctrls {
>> @@ -128,6 +126,7 @@ struct cppc_perf_ctrls {
>> u32 min_perf;
>> u32 desired_perf;
>> u32 energy_perf;
>> + bool auto_sel;
>> };
>>
>> struct cppc_perf_fb_ctrs {
>> --
> It looks like this patch and the next one can be applied independently
> of the other patches in the series.
>
> Do you want me to do that?
Yes, this patch is independent and can be applied.
Also, the 'patch 3' can be applied independently.
- patch 3: 'ACPI: CPPC: Rename EPP constants for clarity'
Thank you,
Sumit Gupta
Powered by blists - more mailing lists