linux-kernel - Re: [PATCH v2] stm class: Fix Kconfig symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d46a7e44-cddf-425c-a233-911c2d949b9b@infradead.org>
Date: Tue, 27 Jan 2026 11:15:17 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Leo Yan <leo.yan@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 James Clark <james.clark@...aro.org>
Cc: linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, coresight@...ts.linaro.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] stm class: Fix Kconfig symbols

On 1/27/26 10:14 AM, Leo Yan wrote:
> Kconfig symbols must not include the CONFIG_ prefix.  Remove the CONFIG_
> prefix for default values to work.
> 
> The STM_PROTO_SYS_T config is selected by default when STM is enabled.
> However, its description currently says "If you don't know what this is,
> say N," which contradicts the default behavior.  Update the description
> to say "Y" to align with the default setting.
> 
> Fixes: a02509f301c6 ("stm class: Factor out default framing protocol")
> Fixes: d69d5e83110f ("stm class: Add MIPI SyS-T protocol support")
> Signed-off-by: Leo Yan <leo.yan@....com>

Greg has already merged a patch to fix the symbols:
https://patch.msgid.link/20251228190502.2480758-1-rdunlap@infradead.org


> ---
> Changes in v2:
> - Updated STM_PROTO_BASIC description to align with default selection
>   (James).
> - Link to v1: https://lore.kernel.org/r/20251217-fix_stm_kconfig-v1-1-531fb3674549@arm.com
> ---
>  drivers/hwtracing/stm/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
> index eda6b11d40a1f9ab49a1ec1e6faae8ee178c5ed3..8ab079785189052945521e9b0a93a0d458de37e0 100644
> --- a/drivers/hwtracing/stm/Kconfig
> +++ b/drivers/hwtracing/stm/Kconfig
> @@ -13,7 +13,7 @@ if STM
>  
>  config STM_PROTO_BASIC
>  	tristate "Basic STM framing protocol driver"
> -	default CONFIG_STM
> +	default STM
>  	help
>  	  This is a simple framing protocol for sending data over STM
>  	  devices. This was the protocol that the STM framework used
> @@ -28,7 +28,7 @@ config STM_PROTO_BASIC
>  
>  config STM_PROTO_SYS_T
>  	tristate "MIPI SyS-T STM framing protocol driver"
> -	default CONFIG_STM
> +	default STM
>  	help
>  	  This is an implementation of MIPI SyS-T protocol to be used
>  	  over the STP transport. In addition to the data payload, it
> @@ -38,7 +38,7 @@ config STM_PROTO_SYS_T
>  	  The receiving side must be able to decode this protocol in
>  	  addition to the MIPI STP, in order to extract the data.
>  
> -	  If you don't know what this is, say N.
> +	  If you don't know what this is, say Y.
>  
>  config STM_DUMMY
>  	tristate "Dummy STM driver"
> 
> ---
> base-commit: fcb70a56f4d81450114034b2c61f48ce7444a0e2
> change-id: 20251216-fix_stm_kconfig-a72f40c7612c
> 
> Best regards,