linux-kernel - Re: [PATCH] media: synopsys: VIDEO_DW_MIPI_CSI2RX should depend on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d3b9fe8c-688f-48a2-aa00-2f640dec079e@collabora.com>
Date: Tue, 27 Jan 2026 20:24:57 +0100
From: Michael Riesch <michael.riesch@...labora.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Hans Verkuil <hverkuil@...nel.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Mehdi Djait <mehdi.djait@...ux.intel.com>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>, Frank Li <Frank.li@....com>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: synopsys: VIDEO_DW_MIPI_CSI2RX should depend on
 ARCH_ROCKCHIP

Hi Geert,

Thanks for the patch!

On 1/27/26 20:10, Geert Uytterhoeven wrote:
> The Synopsys DesignWare MIPI CSI-2 Receiver is currently only supported
> on Rockchip RK3568 SoCs.  Hence add a dependency on ARCH_ROCKCHIP, to
> prevent asking the user about this driver when configuring a kernel
> without Rockchip platform support.
> 
> The dependency can be relaxed later, when adding support for appropriate
> SoCs from other vendors (if any).

No objections from my side. I kicked out exactly this line when I moved
the driver from rockchip to synopsys, as I thought there shouldn't be
any Rockchip-specific bits.

Cc: Frank (since he aims to build upon this driver IIRC)

> 
> Fixes: 355a110040665e43 ("media: synopsys: add driver for the designware mipi csi-2 receiver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

AFAIC:

Acked-by: Michael Riesch <michael.riesch@...labora.com>

Regards,
Michael

> ---
>  drivers/media/platform/synopsys/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/synopsys/Kconfig b/drivers/media/platform/synopsys/Kconfig
> index e798ec00b1897560..8d0f5e3e8cd58eab 100644
> --- a/drivers/media/platform/synopsys/Kconfig
> +++ b/drivers/media/platform/synopsys/Kconfig
> @@ -4,6 +4,7 @@ source "drivers/media/platform/synopsys/hdmirx/Kconfig"
>  
>  config VIDEO_DW_MIPI_CSI2RX
>  	tristate "Synopsys DesignWare MIPI CSI-2 Receiver"
> +	depends on ARCH_ROCKCHIP || COMPILE_TEST
>  	depends on VIDEO_DEV
>  	depends on V4L_PLATFORM_DRIVERS
>  	depends on PM && COMMON_CLK