linux-kernel - Re: [PATCH net v3 0/3] net: liquidio: Fix memory leaks in setup_nic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260127130546.7f53b313@kernel.org>
Date: Tue, 27 Jan 2026 13:05:46 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Zilin Guan <zilin@....edu.cn>
Cc: horms@...nel.org, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, jianhao.xu@....edu.cn, kory.maincent@...tlin.com,
 linux-kernel@...r.kernel.org, marco.crivellari@...e.com,
 netdev@...r.kernel.org, pabeni@...hat.com, vadim.fedorenko@...ux.dev
Subject: Re: [PATCH net v3 0/3] net: liquidio: Fix memory leaks in
 setup_nic_devices()

On Tue, 27 Jan 2026 15:12:38 +0000 Zilin Guan wrote:
> This series fixes memory leaks in the initialization paths of the 
> NIC devices.
> 
> Patch 1 fixes an off-by-one error in the PF cleanup loop. It ensures
> the current device index is cleaned up and correctly handles the 
> post-loop devlink_alloc failure case.
> 
> Patch 2 fixes the same off-by-one error in the VF cleanup loop.
> 
> Patch 3 moves the initialization of oct->props[i].netdev before queue 
> setup calls. This ensures that if queue setup fails, the cleanup function 
> can find and free the allocated netdev. It also initializes lio->oct_dev 
> early to prevent a crash in the cleanup path.

Coccicheck says:

drivers/net/ethernet/cavium/liquidio/lio_main.c:3769:8-9: WARNING: Unsigned expression compared with zero: i >= 0
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:2215:8-9: WARNING: Unsigned expression compared with zero: i >= 0
-- 
pw-bot: cr