[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAPVz0n3b6Oe8B2oyy3U6keFnH2X0GSvNrwJCjVUk5RAf+iwOug@mail.gmail.com>
Date: Tue, 27 Jan 2026 08:50:55 +0200
From: Svyatoslav Ryhel <clamor95@...il.com>
To: Lars Melin <larsm17@...il.com>
Cc: Oliver Neukum <oneukum@...e.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] usb: csc-acm: add Infineon/Comneon modem support (1519:0020)
вт, 27 січ. 2026 р. о 03:12 Lars Melin <larsm17@...il.com> пише:
>
> On 2026-01-26 21:55, Svyatoslav Ryhel wrote:
> /snip
> >
> > Bus 001 Device 002: ID 1519:0020 Comneon HSIC Device
> > Couldn't open device, some information will be missing
> > Negotiated speed: High Speed (480Mbps)
> > Device Descriptor:
> > bLength 18
> > bDescriptorType 1
> > bcdUSB 2.00
> > bDeviceClass 2 [unknown]
> > bDeviceSubClass 0 [unknown]
> > bDeviceProtocol 0
> > bMaxPacketSize0 64
> > idVendor 0x1519 Comneon
> > idProduct 0x0020 HSIC Device
> > bcdDevice 12.74
> > iManufacturer 1 Comneon
> > iProduct 2 HSIC Device
> > iSerial 3 0123456789
> > bNumConfigurations 1
> > Configuration Descriptor:
> > bLength 9
> > bDescriptorType 2
> > wTotalLength 0x0111
> > bNumInterfaces 8
> > bConfigurationValue 1
> > iConfiguration 0
> > bmAttributes 0xc0
> > Self Powered
> > MaxPower 100mA
> > Interface Association:
> > bLength 8
> > bDescriptorType 11
> > bFirstInterface 0
> > bInterfaceCount 2
> > bFunctionClass 2 [unknown]
> > bFunctionSubClass 2 [unknown]
> > bFunctionProtocol 1
> > iFunction 0
> > Interface Descriptor:
> > bLength 9
> > bDescriptorType 4
> > bInterfaceNumber 0
> > bAlternateSetting 0
> > bNumEndpoints 1
> > bInterfaceClass 2 [unknown]
> > bInterfaceSubClass 2 [unknown]
> > bInterfaceProtocol 1
> > iInterface 4
> > CDC Header:
> > bcdCDC 1.10
> > CDC Union:
> > bMasterInterface 0
> > bSlaveInterface 1
> > CDC Call Management:
> > bmCapabilities 0x00
> > bDataInterface 1
> > CDC ACM:
> > bmCapabilities 0x07
> > sends break
> > line coding and serial state
> > get/set/clear comm features
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x85 EP 5 IN
> > bmAttributes 3
> > Transfer Type Interrupt
> > Synch Type None
> > Usage Type Data
> > wMaxPacketSize 0x0040 1x 64 bytes
> > bInterval 4
> > Interface Descriptor:
> > bLength 9
> > bDescriptorType 4
> > bInterfaceNumber 1
> > bAlternateSetting 0
> > bNumEndpoints 2
> > bInterfaceClass 10 [unknown]
> > bInterfaceSubClass 0 [unknown]
> > bInterfaceProtocol 0
> > iInterface 5
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x81 EP 1 IN
> > bmAttributes 2
> > Transfer Type Bulk
> > Synch Type None
> > Usage Type Data
> > wMaxPacketSize 0x0200 1x 512 bytes
> > bInterval 0
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x01 EP 1 OUT
> > bmAttributes 2
> > Transfer Type Bulk
> > Synch Type None
> > Usage Type Data
> > wMaxPacketSize 0x0200 1x 512 bytes
> > bInterval 0
> > Interface Association:
> > bLength 8
> > bDescriptorType 11
> > bFirstInterface 2
> > bInterfaceCount 2
> > bFunctionClass 2 [unknown]
> > bFunctionSubClass 2 [unknown]
> > bFunctionProtocol 1
> > iFunction 0
> > Interface Descriptor:
> > bLength 9
> > bDescriptorType 4
> > bInterfaceNumber 2
> > bAlternateSetting 0
> > bNumEndpoints 1
> > bInterfaceClass 2 [unknown]
> > bInterfaceSubClass 2 [unknown]
> > bInterfaceProtocol 1
> > iInterface 6
> > CDC Header:
> > bcdCDC 1.10
> > CDC Union:
> > bMasterInterface 2
> > bSlaveInterface 3
> > CDC Call Management:
> > bmCapabilities 0x00
> > bDataInterface 3
> > CDC ACM:
> > bmCapabilities 0x07
> > sends break
> > line coding and serial state
> > get/set/clear comm features
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x86 EP 6 IN
> > bmAttributes 3
> > Transfer Type Interrupt
> > Synch Type None
> > Usage Type Data
> > wMaxPacketSize 0x0040 1x 64 bytes
> > bInterval 4
> > Interface Descriptor:
> > bLength 9
> > bDescriptorType 4
> > bInterfaceNumber 3
> > bAlternateSetting 0
> > bNumEndpoints 2
> > bInterfaceClass 10 [unknown]
> > bInterfaceSubClass 0 [unknown]
> > bInterfaceProtocol 0
> > iInterface 7
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x82 EP 2 IN
> > bmAttributes 2
> > Transfer Type Bulk
> > Synch Type None
> > Usage Type Data
> > wMaxPacketSize 0x0200 1x 512 bytes
> > bInterval 0
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x02 EP 2 OUT
> > bmAttributes 2
> > Transfer Type Bulk
> > Synch Type None
> > Usage Type Data
> > wMaxPacketSize 0x0200 1x 512 bytes
> > bInterval 0
> > Interface Association:
> > bLength 8
> > bDescriptorType 11
> > bFirstInterface 4
> > bInterfaceCount 2
> > bFunctionClass 2 [unknown]
> > bFunctionSubClass 2 [unknown]
> > bFunctionProtocol 1
> > iFunction 0
> > Interface Descriptor:
> > bLength 9
> > bDescriptorType 4
> > bInterfaceNumber 4
> > bAlternateSetting 0
> > bNumEndpoints 1
> > bInterfaceClass 2 [unknown]
> > bInterfaceSubClass 2 [unknown]
> > bInterfaceProtocol 1
> > iInterface 8
> > CDC Header:
> > bcdCDC 1.10
> > CDC Union:
> > bMasterInterface 4
> > bSlaveInterface 5
> > CDC Call Management:
> > bmCapabilities 0x00
> > bDataInterface 5
> > CDC ACM:
> > bmCapabilities 0x07
> > sends break
> > line coding and serial state
> > get/set/clear comm features
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x87 EP 7 IN
> > bmAttributes 3
> > Transfer Type Interrupt
> > Synch Type None
> > Usage Type Data
> > wMaxPacketSize 0x0040 1x 64 bytes
> > bInterval 4
> > Interface Descriptor:
> > bLength 9
> > bDescriptorType 4
> > bInterfaceNumber 5
> > bAlternateSetting 0
> > bNumEndpoints 2
> > bInterfaceClass 10 [unknown]
> > bInterfaceSubClass 0 [unknown]
> > bInterfaceProtocol 0
> > iInterface 9
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x83 EP 3 IN
> > bmAttributes 2
> > Transfer Type Bulk
> > Synch Type None
> > Usage Type Data
> > wMaxPacketSize 0x0200 1x 512 bytes
> > bInterval 0
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x03 EP 3 OUT
> > bmAttributes 2
> > Transfer Type Bulk
> > Synch Type None
> > Usage Type Data
> > wMaxPacketSize 0x0200 1x 512 bytes
> > bInterval 0
> > Interface Association:
> > bLength 8
> > bDescriptorType 11
> > bFirstInterface 6
> > bInterfaceCount 2
> > bFunctionClass 2 [unknown]
> > bFunctionSubClass 2 [unknown]
> > bFunctionProtocol 1
> > iFunction 0
> > Interface Descriptor:
> > bLength 9
> > bDescriptorType 4
> > bInterfaceNumber 6
> > bAlternateSetting 0
> > bNumEndpoints 1
> > bInterfaceClass 2 [unknown]
> > bInterfaceSubClass 2 [unknown]
> > bInterfaceProtocol 1
> > iInterface 10
> > CDC Header:
> > bcdCDC 1.10
> > CDC Union:
> > bMasterInterface 6
> > bSlaveInterface 7
> > CDC Call Management:
> > bmCapabilities 0x00
> > bDataInterface 7
> > CDC ACM:
> > bmCapabilities 0x07
> > sends break
> > line coding and serial state
> > get/set/clear comm features
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x88 EP 8 IN
> > bmAttributes 3
> > Transfer Type Interrupt
> > Synch Type None
> > Usage Type Data
> > wMaxPacketSize 0x0040 1x 64 bytes
> > bInterval 4
> > Interface Descriptor:
> > bLength 9
> > bDescriptorType 4
> > bInterfaceNumber 7
> > bAlternateSetting 0
> > bNumEndpoints 2
> > bInterfaceClass 10 [unknown]
> > bInterfaceSubClass 0 [unknown]
> > bInterfaceProtocol 0
> > iInterface 11
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x84 EP 4 IN
> > bmAttributes 2
> > Transfer Type Bulk
> > Synch Type None
> > Usage Type Data
> > wMaxPacketSize 0x0200 1x 512 bytes
> > bInterval 0
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x04 EP 4 OUT
> > bmAttributes 2
> > Transfer Type Bulk
> > Synch Type None
> > Usage Type Data
> > wMaxPacketSize 0x0200 1x 512 bytes
> > bInterval 0
> >
> Hi,
>
> I can't see anything wrong with the union descriptor in your listing.
> What is your reason for adding this device to cdc-acm?
>
Oh, that is good to hear. I have LG Optimus Vu (P895) Tegra30 based
smartphone, it uses this modem which is placed on HSIC usb line and I
have recently made it appear.
Original LG downstream sources[1] add this device to acm_ids with
NO_UNION_NORMAL so I transferred this change to mainline.
[1] https://github.com/clamor-s/android_kernel_lge_p895/blob/master/drivers/usb/class/cdc-acm.c#L1837-L1839
> thanks
> Lars
Powered by blists - more mailing lists