linux-kernel - Re: [PATCH] mm/cma: Replace snprintf with strscpy in cma_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260127010511.74604-1-sj@kernel.org>
Date: Mon, 26 Jan 2026 17:05:10 -0800
From: SeongJae Park <sj@...nel.org>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: SeongJae Park <sj@...nel.org>,
	Thorsten Blum <thorsten.blum@...ux.dev>,
	David Hildenbrand <david@...nel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	"Liam R. Howlett" <Liam.Howlett@...cle.com>,
	Vlastimil Babka <vbabka@...e.cz>,
	Mike Rapoport <rppt@...nel.org>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Michal Hocko <mhocko@...e.com>,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/cma: Replace snprintf with strscpy in cma_new_area

On Mon, 26 Jan 2026 16:54:50 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Mon, 26 Jan 2026 16:47:22 -0800 SeongJae Park <sj@...nel.org> wrote:
> 
> > > @@ -233,7 +234,7 @@ static int __init cma_new_area(const char *name, phys_addr_t size,
> > >  	cma_area_count++;
> > >  
> > >  	if (name)
> > > -		snprintf(cma->name, CMA_MAX_NAME, "%s", name);
> > > +		strscpy(cma->name, name);
> > 
> > Any reason to drop CMA_MAX_NAME protection?  You can pass the size of
> > destination buffer as the third argument of strscpy().
> 
> strscpy() will now use sizeof(cma->name):
> 
> 	char name[CMA_MAX_NAME];

Ah, you're right.

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ