linux-kernel - Re: [PATCH 3/3] KVM: VMX: Print out "bad" offsets+value on VMCS config mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXhvD9DT4YtKAcIr@intel.com>
Date: Tue, 27 Jan 2026 15:53:51 +0800
From: Chao Gao <chao.gao@...el.com>
To: Sean Christopherson <seanjc@...gle.com>
CC: Paolo Bonzini <pbonzini@...hat.com>, <kvm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Mathias Krause <minipli@...ecurity.net>,
	"John Allen" <john.allen@....com>, Rick Edgecombe
	<rick.p.edgecombe@...el.com>, Binbin Wu <binbin.wu@...ux.intel.com>, Xiaoyao
 Li <xiaoyao.li@...el.com>, "Jim Mattson" <jmattson@...gle.com>
Subject: Re: [PATCH 3/3] KVM: VMX: Print out "bad" offsets+value on VMCS
 config mismatch

On Mon, Jan 26, 2026 at 06:57:26AM -0800, Sean Christopherson wrote:
>On Fri, Jan 23, 2026, Sean Christopherson wrote:
>> +			pr_cont("  Offset %lu REF = 0x%08x, CPU%u = 0x%08x, mismatch = 0x%08x\n",
>> +				i * sizeof(u32), gold[i], cpu, mine[i], gold[i] ^ mine[i]);
>
>As pointed out by the kernel bot, sizeof() isn't an unsigned long on 32-bit.
>Simplest fix is to force it to an int.
>
>			pr_cont("  Offset %u REF = 0x%08x, CPU%u = 0x%08x, mismatch = 0x%08x\n",
>				i * (int)sizeof(u32), gold[i], cpu, mine[i], gold[i] ^ mine[i]);

Why pr_cont()? The previous line ends with '\n'. so, a plain pr_err() should work.

Anyway, the code looks good.

Reviewed-by: Chao Gao <chao.gao@...el.com>