linux-kernel - Re: [PATCH] gpiolib: acpi: use BIT_ULL() for u64 mask in address space handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260127080759.GY2275908@black.igk.intel.com>
Date: Tue, 27 Jan 2026 09:07:59 +0100
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Denis Sergeev <denserg.edu@...il.com>
Cc: westeri@...nel.org, andriy.shevchenko@...ux.intel.com,
	linusw@...nel.org, brgl@...nel.org, linux-gpio@...r.kernel.org,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	lvc-project@...uxtesting.org
Subject: Re: [PATCH] gpiolib: acpi: use BIT_ULL() for u64 mask in address
 space handler

On Mon, Jan 26, 2026 at 06:59:14AM +0300, Denis Sergeev wrote:
> The BIT() macro uses unsigned long, which is 32 bits on 32-bit
> architectures. When iterating over GPIO pins with index >= 32,
> the expression (*value & BIT(i)) causes undefined behavior due
> to shifting by a value >= type width.
> 
> Since 'value' is a pointer to u64, use BIT_ULL() to ensure correct
> 64-bit mask on all architectures.
> 
> Found by Linux Verification Center (linuxtesting.org) with Svace.
> 
> Fixes: 2c4d00cb8fc5 ("gpiolib: acpi: Use BIT() macro to increase readability")
> Signed-off-by: Denis Sergeev <denserg.edu@...il.com>

Reviewed-by: Mika Westerberg <westeri@...nel.org>