[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20260127083845.3681331-1-andriy.shevchenko@linux.intel.com>
Date: Tue, 27 Jan 2026 09:38:45 +0100
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org
Cc: Andy Shevchenko <andy@...nel.org>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Linus Walleij <linusw@...nel.org>
Subject: [PATCH v1 1/1] pinctrl: tangier: Join tng_pinctrl_probe() in its wrapper
There is no clear sign why we have tng_pinctrl_probe() in the first
place when it has already been using managed calls. Join the function
to its devm_tng_pinctrl_probe() wrapper.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
---
drivers/pinctrl/intel/pinctrl-tangier.c | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-tangier.c b/drivers/pinctrl/intel/pinctrl-tangier.c
index 5f0b7334a489..44b333d6c7cb 100644
--- a/drivers/pinctrl/intel/pinctrl-tangier.c
+++ b/drivers/pinctrl/intel/pinctrl-tangier.c
@@ -518,15 +518,19 @@ static const struct pinctrl_desc tng_pinctrl_desc = {
.owner = THIS_MODULE,
};
-static int tng_pinctrl_probe(struct platform_device *pdev,
- const struct tng_pinctrl *data)
+int devm_tng_pinctrl_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
+ const struct tng_pinctrl *data;
struct tng_family *families;
struct tng_pinctrl *tp;
void __iomem *regs;
unsigned int i;
+ data = device_get_match_data(dev);
+ if (!data)
+ return -ENODATA;
+
tp = devm_kmemdup(dev, data, sizeof(*data), GFP_KERNEL);
if (!tp)
return -ENOMEM;
@@ -566,17 +570,6 @@ static int tng_pinctrl_probe(struct platform_device *pdev,
return 0;
}
-
-int devm_tng_pinctrl_probe(struct platform_device *pdev)
-{
- const struct tng_pinctrl *data;
-
- data = device_get_match_data(&pdev->dev);
- if (!data)
- return -ENODATA;
-
- return tng_pinctrl_probe(pdev, data);
-}
EXPORT_SYMBOL_NS_GPL(devm_tng_pinctrl_probe, "PINCTRL_TANGIER");
MODULE_AUTHOR("Andy Shevchenko <andriy.shevchenko@...ux.intel.com>");
--
2.50.1
Powered by blists - more mailing lists