linux-kernel - Re: [PATCH] fork: clarify copy_mm() comment for kernel thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXiIHEH7Yt53fXNI@JMW-Ubuntu>
Date: Tue, 27 Jan 2026 18:40:44 +0900
From: Minu Jin <s9430939@...er.com>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
	vincent.guittot@...aro.org, akpm@...ux-foundation.org,
	david@...nel.org, kees@...nel.org, dietmar.eggemann@....com,
	rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
	vschneid@...hat.com, Liam.Howlett@...cle.com, vbabka@...e.cz,
	rppt@...nel.org, surenb@...gle.com, mhocko@...e.com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] fork: clarify copy_mm() comment for kernel thread

On Tue, Jan 27, 2026 at 09:25:26AM +0000, Lorenzo Stoakes wrote:
> On Tue, Jan 27, 2026 at 02:53:21PM +0900, Minu Jin wrote:
> > The existing comment is misleading:
> >
> >     1. "steal a active VM" suggests this code performs the active_mm
> >        borrowing, but the actual borrowing happens in context_switch()
> >        where 'next->active_mm = prev->active_mm' is assigned.
> >        This code simply returns 0 to skip mm copying for kernel threads.
> 
> Yeah but the comment as it stands implies that you are doing that elsewhere
> so I don't think this is a problem.
> 
> Referring to a specific other function in a comment unnecessarily makes
> bitrot easier.
> 
> >
> >     2. "active VM" is outdated terminology, the kernel uses "active_mm".
> 
> Well VM refers to the virtual address space so it's perfectly fine
> terminology.
> 
> >
> > Update the comment to accurately describe what this code does.
> 
> I hate to say it but this sort of enumerated list is very AI-like so if you
> are sending a patch that is AI-generated please do indicate that this is so
> (and put e.g. Co-Developed-by: <whatever>) if so.
> 
> >
> > Signed-off-by: Minu Jin <s9430939@...er.com>
> 
> Thanks for the patch but I honestly don't think this is all that
> misleading. This original comment is from 2005 and I don't think anybody's
> been all that confused by it in the meantime.
> 
> So I don't think we should take this.
> 
> Cheers, Lorenzo
> 

Hi Lorenzo,

Thanks for your feedback and historical context.
I understand your point about preserving the existing comment.

About 'AI-like' formatting:
I am not a native English speaker, 
so I used an AI tool to help structure and refine my English sentences
for better clarity.

However, the technical analysis and the logic in the patch 
were entirely my own findings from studying the code.

I'll keep your advice in mind regarding 'bitrot' and will focus
on more impactful technical issues in the future.

Thanks again for the review.

Minu Jin.