linux-kernel - Re: [PATCH net-next v2] devlink: Implement devlink param multi attribute nested data values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rsngz5ql5s54luv4mnjs733uogjjdxiylbbm4w4pcaefow45rm@memr4a27ycc2>
Date: Tue, 27 Jan 2026 10:51:10 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Ratheesh Kannoth <rkannoth@...vell.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Saeed Mahameed <saeedm@...dia.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Donald Hunter <donald.hunter@...il.com>, Chuck Lever <chuck.lever@...cle.com>, 
	"Matthieu Baerts (NGI0)" <matttbe@...nel.org>, Carolina Jubran <cjubran@...dia.com>
Subject: Re: [PATCH net-next v2] devlink: Implement devlink param multi
 attribute nested data values

Tue, Jan 27, 2026 at 02:18:59AM +0100, kuba@...nel.org wrote:
>On Mon, 26 Jan 2026 08:09:44 +0530 Ratheesh Kannoth wrote:
>> Devlink param value attribute is not defined since devlink is handling
>> the value validating and parsing internally, this allows us to implement
>> multi attribute values without breaking any policies.
>> 
>> Devlink param multi-attribute values are considered to be dynamically
>> sized arrays of u32 values, by introducing a new devlink param type
>> DEVLINK_PARAM_TYPE_U32_ARRAY, driver and user space can set a variable
>> count of u32 values into the DEVLINK_ATTR_PARAM_VALUE_DATA attribute.
>> 
>> Implement get/set parsing and add to the internal value structure passed
>> to drivers.
>> 
>> This is useful for devices that need to configure a list of values for
>> a specific configuration.
>
>Could you respin this as a series with the first driver implementing
>a param of this type?  We can't merge an API without a user.

I may be missed it, are you okay with cleanup helpers now (__free(kfree)
used here), or not yet? :)