linux-kernel - Re: [PATCH] gpio/rockchip: Stop calling pinctrl for set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD++jLk_ATHWwt_e+KN1+2sLYxqB4n-mdrbdxUHpHvnryeF+fg@mail.gmail.com>
Date: Tue, 27 Jan 2026 11:00:46 +0100
From: Linus Walleij <linusw@...nel.org>
To: Bartosz Golaszewski <brgl@...nel.org>
Cc: Robin Murphy <robin.murphy@....com>, heiko@...ech.de, sebastian.reichel@...labora.com, 
	m.szyprowski@...sung.com, linux-rockchip@...ts.infradead.org, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH] gpio/rockchip: Stop calling pinctrl for set_direction

On Mon, Jan 26, 2026 at 2:48 PM Bartosz Golaszewski <brgl@...nel.org> wrote:
> On Mon, Jan 26, 2026 at 1:12 PM Robin Murphy <robin.murphy@....com> wrote:
> >
> > Marking the whole controller as sleeping due to the pinctrl calls in the
> > .direction_{input,output} callbacks has the unfortunate side effect that
> > legitimate invocations of .get and .set, which cannot themselves sleep,
> > in atomic context now spew WARN()s from gpiolib.
> >
> > However, as Heiko points out, the driver doing this is a bit silly to
> > begin with, as the pinctrl .gpio_set_direction hook doesn't even care
> > about the direction, the hook is only used to claim the mux. And sure
> > enough, the .gpio_request_enable hook exists to serve this very purpose,
> > so switch to that and remove the problematic business entirely.
> >
> > Cc: stable@...r.kernel.org
> > Fixes: 20cf2aed89ac ("gpio: rockchip: mark the GPIO controller as sleeping")
> > Suggested-by: Heiko Stuebner <heiko@...ech.de>
> > Signed-off-by: Robin Murphy <robin.murphy@....com>
> > ---
>
> Linus,
>
> With your Ack I can queue this for v6.19-rc8.

Late to the show :)

Heiko's ACK is more than enough for this driver, he knows
Rockchip way better than me.

Yours,
Linus Walleij