linux-kernel - Re: [PATCH v2 8/8] iio: dac: ds4424: ratelimit read errors and use device context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXiXy8TJfb4eV1va@smile.fi.intel.com>
Date: Tue, 27 Jan 2026 12:47:39 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, Andy Shevchenko <andy@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	David Jander <david@...tonic.nl>
Subject: Re: [PATCH v2 8/8] iio: dac: ds4424: ratelimit read errors and use
 device context

On Tue, Jan 27, 2026 at 07:09:39AM +0100, Oleksij Rempel wrote:
> Replace pr_err() with dev_err_ratelimited() in the RAW read path to avoid
> log spam on repeated I2C failures and to include the device context.
> 
> Use %pe to print errno names for faster debugging.

This should have been done before touching this line in the other patch.

...

>  		if (ret < 0) {
> -			pr_err("%s : regmap_read returned %d\n",
> -						__func__, ret);
> +			dev_err_ratelimited(&indio_dev->dev,

Why not physical device?

> +					    "Failed to read channel %d:  %pe\n",

Too many spaces.

> +					    chan->channel, ERR_PTR(ret));
>  			return ret;
>  		}

-- 
With Best Regards,
Andy Shevchenko