linux-kernel - Re: [PATCH v2 6/8] iio: dac: ds4424: fix -128 rejection and refactor raw access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXiYty1gFMcmC4lT@smile.fi.intel.com>
Date: Tue, 27 Jan 2026 12:51:35 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, stable@...r.kernel.org,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	Andy Shevchenko <andy@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	David Jander <david@...tonic.nl>
Subject: Re: [PATCH v2 6/8] iio: dac: ds4424: fix -128 rejection and refactor
 raw access

On Tue, Jan 27, 2026 at 11:49:05AM +0100, Oleksij Rempel wrote:
> On Tue, Jan 27, 2026 at 12:42:24PM +0200, Andy Shevchenko wrote:
> > On Tue, Jan 27, 2026 at 07:09:37AM +0100, Oleksij Rempel wrote:

...

> > > +		/*
> > > +		 * Currents exiting the IC (Source) are positive.
> > > +		 * Canonicalize 0 to sink; datasheet treats sign as don't-care.
> > > +		 */
> > > +		if (val > 0)
> > > +			abs_val |= DS4424_DAC_SOURCE;
> > 
> > Hmm... Maybe 0 should be excluded as invalid?
> 
> 0 is valid value for no current flow (power off). The direction bit
> DS4424_DAC_SOURCE  will just make no difference if value is 0.

Perhaps elaborate this in the comment above?

-- 
With Best Regards,
Andy Shevchenko