linux-kernel - Re: [PATCH net v3] net: spacemit: Check for netif_carrier_ok() in emac_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c357d72-2a73-47d8-9ec7-56a2912a2e10@kernel.org>
Date: Tue, 27 Jan 2026 12:02:38 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Vivian Wang <wangruikang@...as.ac.cn>
Cc: Chukun Pan <amadeus@....edu.cn>,
 Michael Opdenacker <michael.opdenacker@...tcommit.com>,
 netdev@...r.kernel.org, linux-riscv@...ts.infradead.org,
 spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org,
 Mark Brown <broonie@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Yixun Lan <dlan@...too.org>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Maxime Chevallier <maxime.chevallier@...tlin.com>,
 Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
 Alexandre Ghiti <alex@...ti.fr>,
 Troy Mitchell <troy.mitchell@...ux.spacemit.com>
Subject: Re: [PATCH net v3] net: spacemit: Check for netif_carrier_ok() in
 emac_stats_update(): manual merge

Hi Vivian,

+cc Mark Brown

On 23/01/2026 04:52, Vivian Wang wrote:
> Some PHYs stop the refclk for power saving, usually while link down.
> This causes reading stats to time out.
> 
> Therefore, in emac_stats_update(), also don't update and reschedule if
> !netif_carrier_ok(). But that means we could be missing later updates if
> the link comes back up, so also reschedule when link up is detected in
> emac_adjust_link().
> 
> While we're at it, improve the comments and error message prints around
> this to reflect the better understanding of how this could happen.
> Hopefully if this happens again on new hardware, these comments will
> direct towards a solution.

(...)

> ---
> This has a conflict in context lines in emac_adjust_link() with current
> net-next, which will show up when pulling that for next rc1. Just remove
> "emac_set_fc_autoneg(priv);".

Thank you for this note, this was useful! Just in case it can be useful
for linux-next and Net maintainers, I confirm the conflict when merging
'net' in 'net-next' due to this patch applied in 'net':

  2c84959167d6 ("net: spacemit: Check for netif_carrier_ok() in
emac_stats_update()")

and this one from 'net-next':

  f66086798f91 ("net: spacemit: Remove broken flow control support")

The resolution is attached to this email, and rerere cache is available
there:

 https://github.com/multipath-tcp/mptcp-upstream-rr-cache/commit/526c74b

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

View attachment "7daa0aa370b7e9326e11e06fdb247227773bba0a.patch" of type "text/x-patch" (546 bytes)