linux-kernel - Re: [PATCH] arm64: dts: qcom: talos: add ETR device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad5ce24d-4847-4363-b8a9-69bcd2e4695e@oss.qualcomm.com>
Date: Tue, 27 Jan 2026 13:04:05 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Jie Gan <jie.gan@....qualcomm.com>,
        Bjorn Andersson
 <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Tingwei Zhang <tingwei.zhang@....qualcomm.com>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: talos: add ETR device

On 1/23/26 8:10 AM, Jie Gan wrote:
> Add the TMC ETR device to store collected trace data in DDR memory.
> 
> Signed-off-by: Jie Gan <jie.gan@....qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/talos.dtsi | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
> index 75716b4a58d6..3b081ce9d202 100644
> --- a/arch/arm64/boot/dts/qcom/talos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi
> @@ -2253,6 +2253,14 @@ out-ports {
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  
> +				port@0 {
> +					reg = <0>;
> +
> +					replicator0_out0: endpoint {
> +						remote-endpoint = <&tmc_etr_in>;
> +					};
> +				};
> +
>  				port@1 {
>  					reg = <1>;
>  
> @@ -2287,6 +2295,25 @@ tmc_etf_out: endpoint {
>  			};
>  		};
>  
> +		tmc_etr: tmc@...8000 {

This label is unused, please remove it

Otherwise lgtm

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad