linux-kernel - Re: [PATCH v1 1/3] staging: rtl8723bs: remove dead RX info reset logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXoLCt5q_NkoVt21@stanley.mountain>
Date: Wed, 28 Jan 2026 16:11:38 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ethan Tidmore <ethantidmore06@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Michael Straube <straube.linux@...il.com>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] staging: rtl8723bs: remove dead RX info reset
 logic

On Tue, Jan 27, 2026 at 04:47:36PM -0600, Ethan Tidmore wrote:
> The function rtw_reset_rx_info() and its associated counters in
> struct debug_priv are used to track AMPDU and management frame
> statistics that are never read by the driver.
> 
> Remove the unused function, the write-only struct members, and the
> now-unused pdbgpriv/psdpriv pointers in rtw_free_assoc_resources()
> to clean up the MLME code.
> 
> Signed-off-by: Ethan Tidmore <ethantidmore06@...il.com>

If they're never used, why can we not remove them from the struct
definition as well?

> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index f81a29cd6a78..411339ebab7e 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -819,15 +819,6 @@ static void free_scanqueue(struct	mlme_priv *pmlmepriv)
>  	spin_unlock_bh(&scan_queue->lock);
>  }
>  
> -static void rtw_reset_rx_info(struct debug_priv *pdbgpriv)
> -{
> -	pdbgpriv->dbg_rx_ampdu_drop_count = 0;
> -	pdbgpriv->dbg_rx_ampdu_forced_indicate_count = 0;
> -	pdbgpriv->dbg_rx_ampdu_loss_count = 0;
> -	pdbgpriv->dbg_rx_dup_mgt_frame_drop_count = 0;
> -	pdbgpriv->dbg_rx_ampdu_window_shift_cnt = 0;
> -}
> -
>  static void find_network(struct adapter *adapter)
>  {
>  	struct wlan_network *pwlan = NULL;
> @@ -848,8 +839,6 @@ void rtw_free_assoc_resources(struct adapter *adapter, int lock_scanned_queue)
>  {
>  	struct	mlme_priv *pmlmepriv = &adapter->mlmepriv;
>  	struct wlan_network *tgt_network = &pmlmepriv->cur_network;
> -	struct dvobj_priv *psdpriv = adapter->dvobj;
> -	struct debug_priv *pdbgpriv = &psdpriv->drv_dbg;
>  
>  	if (check_fwstate(pmlmepriv, WIFI_STATION_STATE | WIFI_AP_STATE)) {
>  		struct sta_info *psta;
> @@ -874,7 +863,6 @@ void rtw_free_assoc_resources(struct adapter *adapter, int lock_scanned_queue)
>  	if (lock_scanned_queue)
>  		adapter->securitypriv.key_mask = 0;
>  

This blank line should be deleted as well.

regards,
dan carpenter

> -	rtw_reset_rx_info(pdbgpriv);
>  }
>  
>  /* rtw_indicate_connect: the caller has to lock pmlmepriv->lock */
> -- 
> 2.52.0
>