linux-kernel - Re: [PATCH v2 1/7] serial: 8250: Protect LCR write in shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXoLLq17mWtGzZU7@smile.fi.intel.com>
Date: Wed, 28 Jan 2026 15:12:14 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>, linux-serial@...r.kernel.org,
	qianfan Zhao <qianfanguijin@....com>,
	Adriana Nicolae <adriana@...sta.com>, linux-kernel@...r.kernel.org,
	"Bandal, Shankar" <shankar.bandal@...el.com>,
	"Murthy, Shanth" <shanth.murthy@...el.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2 1/7] serial: 8250: Protect LCR write in shutdown

On Wed, Jan 28, 2026 at 12:52:55PM +0200, Ilpo Järvinen wrote:
> The 8250_dw driver needs to potentially perform very complex operations
> during LCR writes because its BUSY handling prevents updates to LCR
> while UART is BUSY (which is not fully under our control without those
> complex operations). Thus, LCR writes should occur under port's lock.
> 
> Move LCR write under port's lock in serial8250_do_shutdown(). Also
> split the LCR RMW so that the logic is on a separate line for clarity.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko