linux-kernel - Re: [PATCH v2 3/7] serial: 8250: Add serial8250_handle_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1181064f-5e2a-9538-bec3-b05026ac9a5c@linux.intel.com>
Date: Wed, 28 Jan 2026 15:26:07 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
    Jiri Slaby <jirislaby@...nel.org>, 
    linux-serial <linux-serial@...r.kernel.org>, 
    qianfan Zhao <qianfanguijin@....com>, Adriana Nicolae <adriana@...sta.com>, 
    LKML <linux-kernel@...r.kernel.org>, 
    "Bandal, Shankar" <shankar.bandal@...el.com>, 
    "Murthy, Shanth" <shanth.murthy@...el.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2 3/7] serial: 8250: Add
 serial8250_handle_irq_locked()

On Wed, 28 Jan 2026, Andy Shevchenko wrote:

> On Wed, Jan 28, 2026 at 12:52:57PM +0200, Ilpo Järvinen wrote:
> > 8250_port exports serial8250_handle_irq() to HW specific 8250 drivers.
> > It takes port's lock within but a HW specific 8250 driver may want to
> > take port's lock itself, do something, and then call the generic
> > handler in 8250_port but to do that, the caller has to release port's
> > lock for no good reason.
> > 
> > Introduce serial8250_handle_irq_locked() which a HW specific driver can
> > call while already holding port's lock.
> > 
> > As this is new export, put it straight into a namespace (where all 8250
> > exports should eventually be moved).
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> ...
> 
> > +void serial8250_handle_irq_locked(struct uart_port *port, unsigned int iir);
> >  int serial8250_handle_irq(struct uart_port *port, unsigned int iir);
> 
> Looking at these I think at some point we can move to 'u32 iir'.

Yes (though for common 8250 code even u8 would probably suffice).

-- 
 i.