linux-kernel - Re: [PATCH] fbdev: au1100fb: Add missing check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ca6e1cc-7469-450b-a58f-9279412fb9de@gmx.de>
Date: Wed, 28 Jan 2026 14:29:37 +0100
From: Helge Deller <deller@....de>
To: Chen Ni <nichen@...as.ac.cn>, u.kleine-koenig@...libre.com,
 elfring@...rs.sourceforge.net
Cc: linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbdev: au1100fb: Add missing check for clk_enable

On 1/28/26 10:10, Chen Ni wrote:
> Add check for the return value of clk_enable() andreturn the error
> if it fails in order to catch the error.

Why?
If it really fails, the screen and everything stay blank,
so it's even worse....
It seems nobody is actually checking the return value, most likely
because if it fails, the system will sleep forever anyway.
Or am I missing something?

For now I reject this patch.

Helge


> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>   drivers/video/fbdev/au1100fb.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
> index 6251a6b07b3a..5e7a8f018b7b 100644
> --- a/drivers/video/fbdev/au1100fb.c
> +++ b/drivers/video/fbdev/au1100fb.c
> @@ -567,13 +567,16 @@ int au1100fb_drv_suspend(struct platform_device *dev, pm_message_t state)
>   int au1100fb_drv_resume(struct platform_device *dev)
>   {
>   	struct au1100fb_device *fbdev = platform_get_drvdata(dev);
> +	int  ret;
>   
>   	if (!fbdev)
>   		return 0;
>   
>   	memcpy(fbdev->regs, &fbregs, sizeof(struct au1100fb_regs));
>   
> -	clk_enable(fbdev->lcdclk);
> +	ret = clk_enable(fbdev->lcdclk);
> +	if (ret)
> +		return ret;
>   
>   	/* Unblank the LCD */
>   	au1100fb_fb_blank(VESA_NO_BLANKING, &fbdev->info);