linux-kernel - Re: [PATCH] rust: page: add `from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87pl6tsu2i.fsf@t14s.mail-host-address-is-not-set>
Date: Wed, 28 Jan 2026 15:14:29 +0100
From: Andreas Hindborg <a.hindborg@...nel.org>
To: Gary Guo <gary@...yguo.net>, Alice Ryhl <aliceryhl@...gle.com>, Lorenzo
 Stoakes <lorenzo.stoakes@...cle.com>, "Liam R. Howlett"
 <Liam.Howlett@...cle.com>, Miguel Ojeda <ojeda@...nel.org>, Boqun Feng
 <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, Björn
 Roy Baron
 <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>, Trevor
 Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>
Cc: linux-mm@...ck.org, rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: page: add `from_raw()`

"Gary Guo" <gary@...yguo.net> writes:

> On Wed Jan 28, 2026 at 1:22 PM GMT, Andreas Hindborg wrote:
>> Add a method to `Page` that allows construction of a reference instance
>> from `struct page` pointer.
>>
>> Signed-off-by: Andreas Hindborg <a.hindborg@...sung.com>
>> ---
>> Signed-off-by: Andreas Hindborg <a.hindborg@...nel.org>
>> ---
>>  rust/kernel/page.rs | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/rust/kernel/page.rs b/rust/kernel/page.rs
>> index 432fc0297d4a8..f666c92fcf451 100644
>> --- a/rust/kernel/page.rs
>> +++ b/rust/kernel/page.rs
>> @@ -176,6 +176,17 @@ pub fn nid(&self) -> i32 {
>>          unsafe { bindings::page_to_nid(self.as_ptr()) }
>>      }
>>
>> +    /// Create a `&Page` from a raw `struct page` pointer
>> +    ///
>> +    /// # Safety
>> +    ///
>> +    /// `ptr` must be valid for use as a reference for the duration of `'a`.
>> +    pub unsafe fn from_raw<'a>(ptr: *mut bindings::page) -> &'a Self {
>> +        // SAFETY: By function safety requirements, ptr is not null and is
>> +        // valid for use as a reference.
>> +        unsafe { NonNull::new_unchecked(ptr).cast().as_ref() }
>> +    }
>
> This is wrong. `Page` is a wrapper of `struct page*`, not `struct page`.

Oops. Sorry. This goes on top of a conversion of page to `Ownable` that
I did not send yet.

Please disregard.

Best regards,
Andreas Hindborg